[#8314] Public citations view #8400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We care more about the general grouping rather than a citation being e.g. specifically an _academic_ research. It could be some other generally research that we'd want to track.
Reorder and combined routes to a single part in the config/routes.rb.
Rename as compact as this is currently used to render the citation minimally in the sidebar. Updated the CSS classes too which aren't yet used.
gbp
force-pushed
the
8314-public-citations
branch
3 times, most recently
from
d904a6c
to
412a0e9
Compare
gbp
changed the base branch from
develop
to
update-info-request-not-embargoed-query
gbp
force-pushed
the
8314-public-citations
branch
from
412a0e9
to
53c2235
Compare
garethrees
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Looks great! 🎉
Added some bits in #8404 which if you're happy get merged all at the same time.
Use `title` over the `source_url` but fallback if not present.
Makes it easier to view the source of the citation now that we link to the edit form in the admin UI.
Matches the new /citations page and reflects the broader themes that we're interested in tracking.
* Always show the context text * Use the same CTA irrespective of existing citations
Add some basic navigation links to the new public list of citations. It would be nice to add a homepage section for this by extracting out the intro text of citations/index into a partial, but let's leave that for a later release to give people a chance to build up a list of citations before heavier promotion.
gbp
force-pushed
the
8314-public-citations
branch
from
5b533d7
to
1b1bdf3
Compare
|
Merged in 9677315 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8314
What does this do?
Citation#titleanddescriptionfieldsWhy was this needed?
Shows impact of FOI in action.
Screenshots