Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8314] public citations gr #8404

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

garethrees
Copy link
Member

@garethrees garethrees commented Oct 9, 2024

Couple of enhancements to #8400 while I was reviewing.

[skip changelog]

Screenshots

Sorry about the mix of themes.

citations; can't add:

Screenshot 2024-10-09 at 13 28 18

citations; can add:

Screenshot 2024-10-09 at 13 27 29

no citations; can add:

Screenshot 2024-10-09 at 13 29 43

Link in request subnav:

Screenshot 2024-10-09 at 13 27 50

tweaked phrasing / link on new citation form:

Screenshot 2024-10-09 at 13 31 35

Prevent very long URLs overflowing.
Makes it easier to view the source of the citation now that we link to
the edit form in the admin UI.
Matches the new /citations page and reflects the broader themes that
we're interested in tracking.
* Always show the context text
* Use the same CTA irrespective of existing citations
Add some basic navigation links to the new public list of citations.

It would be nice to add a homepage section for this by extracting out
the intro text of citations/index into a partial, but let's leave that
for a later release to give people a chance to build up a list of
citations before heavier promotion.
@gbp gbp merged commit 5b533d7 into 8314-public-citations Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants