Use geometries from schematisation for pipe, weir and orifice #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename usage of geom back to the_geom so this rename is only reflected in the interface * Replace usage of arr_to_attr_dict with label in sql query
margrietpalm
changed the title
martijn-siemerink
approved these changes
Jan 16, 2025
margrietpalm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the_geomof thePipe(BaseLinear) object and setting this based on the connection nodes (https://github.com/nens/threedigrid-builder/blob/master/threedigrid_builder/grid/linear.py#L40-L46) will be skippedthe_geomtoWeirOrifice. Thenthe_geomis used to setLines.line_geometriesNote that modelchecker ensures that geometries of pipes, orifices and weirs do match the connection nodes.