Migrate compute_ctl arg parsing to clap derive #10497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
force-pushed
the
tristan957/cli
branch
from
421f17c to
0760258
Compare
7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6aa1d33 at 2025-01-31T19:01:53.700Z :recycle: |
tristan957
force-pushed
the
tristan957/cli
branch
2 times, most recently
from
c322202 to
4748e2e
Compare
tristan957
force-pushed
the
tristan957/cli
branch
2 times, most recently
from
87fb00f to
6c49da1
Compare
myrrc
approved these changes
Jan 31, 2025
|
Thank you for the review ❤️ |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The primary benefit is the all the ad hoc get_matches() calls are no longer necessary. Now all it takes to get at the CLI arguments is referencing a struct member. Signed-off-by: Tristan Partin <[email protected]>
tristan957
force-pushed
the
tristan957/cli
branch
from
6c49da1 to
6aa1d33
Compare
|
Rebasing on main to see if it fixes the merge queue issue |
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
The primary benefit is that all the ad hoc get_matches() calls are no longer necessary. Now all it takes to get at the CLI arguments is referencing a struct member. It's also great the we can replace the ad hoc CLI struct we had with this more formal solution. Signed-off-by: Tristan Partin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary benefit is that all the ad hoc get_matches() calls are no longer necessary. Now all it takes to get at the CLI arguments is referencing a struct member. It's also great the we can replace the ad hoc CLI struct we had with this more formal solution.