Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update O2IMS provisionedResources to provisionedResourceSet per CRD #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkosteck
Copy link
Contributor

@dkosteck dkosteck commented Feb 3, 2025

Alok pointed out that the original yaml we received had an old field that did not match the CR, updating that field.

Copy link
Contributor

nephio-prow bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign arora-sagar for approval by writing /assign @arora-sagar in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Collaborator

efiacor commented Feb 4, 2025

@dkosteck requires a rebase I believe.

@dkosteck
Copy link
Contributor Author

dkosteck commented Feb 4, 2025

@dkosteck requires a rebase I believe.

@efiacor Yes, looks like it. Let's wait to see if we get a thumbs up from Alok or Stefan on the CRD since they pointed out the issue with the naming, and originally supplied the updated CRD.

@gupta-alok
Copy link

LGTM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants