Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#588 - Add missing repository rbac roles for porch controllers #56

Merged
merged 4 commits into from
May 27, 2024

Conversation

kushnaidu
Copy link
Contributor

@kushnaidu kushnaidu commented May 21, 2024

This change adds missing repository rbac roles for the porch controllers.

Context -
The use cases are working, but after someone creates a PVS or PV and points to a repo, the controller logs are populated with errors saying the controllers cannot 'get' the repositories.

@liamfallon
Copy link
Member

Could you add some context around this PR please?

@kushnaidu
Copy link
Contributor Author

Could you add some context around this PR please?

just updated the PR description

@liamfallon
Copy link
Member

/approve

Looks fine to me but let's get some more reviews.

@nephio-prow nephio-prow bot added the approved label May 22, 2024
Signed-off-by: Kushal Harish Naidu <[email protected]>
@nagygergo
Copy link
Contributor

/lgtm

Copy link
Contributor

nephio-prow bot commented May 24, 2024

@nagygergo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nagygergo
Copy link
Contributor

/approve

1 similar comment
@Catalin-Stratulat-Ericsson
Copy link
Contributor

/approve

Copy link
Contributor

nephio-prow bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, kushnaidu, liamfallon, nagygergo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 27, 2024
@nephio-prow nephio-prow bot merged commit f50aa13 into nephio-project:main May 27, 2024
5 checks passed
@kushnaidu kushnaidu deleted the controllers-repositories-rbac branch May 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants