Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter CI pipeline #3

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add linter CI pipeline #3

merged 2 commits into from
Sep 17, 2024

Conversation

henrybear327
Copy link
Collaborator

@henrybear327 henrybear327 commented Aug 29, 2024 •
edited
Loading

No description provided.

@henrybear327 henrybear327 self-assigned this Aug 29, 2024
@henrybear327 henrybear327 changed the title Add linter [WIP] Add linter Aug 29, 2024
@henrybear327 henrybear327 marked this pull request as draft September 3, 2024 14:08
@henrybear327 henrybear327 changed the title [WIP] Add linter Add linter and integration test CI pipeline Sep 3, 2024
@henrybear327 henrybear327 force-pushed the ci/add_linter branch 4 times, most recently from 519f8b9 to 492597d Compare September 4, 2024 16:58
@henrybear327 henrybear327 marked this pull request as ready for review September 4, 2024 16:58
@henrybear327 henrybear327 changed the title Add linter and integration test CI pipeline Add linter CI pipeline Sep 4, 2024
@henrybear327 henrybear327 mentioned this pull request Sep 4, 2024
Merged
@henrybear327
Copy link
Collaborator Author

The license header part is under discussion. Moving to draft state.

@henrybear327 henrybear327 marked this pull request as draft September 6, 2024 13:45
@henrybear327 henrybear327 force-pushed the ci/add_linter branch 5 times, most recently from fc82c52 to f81db66 Compare September 13, 2024 11:11
@henrybear327
Copy link
Collaborator Author

The license header part is under discussion. Moving to draft state.

Splitting the license header check to #60

@henrybear327 henrybear327 marked this pull request as ready for review September 13, 2024 11:14
@henrybear327
Copy link
Collaborator Author

Linter errors have been fixed with this PR!

alexandernorth
alexandernorth approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@alexandernorth alexandernorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@henrybear327 henrybear327 merged commit 14eef82 into main Sep 17, 2024
5 checks passed
@henrybear327 henrybear327 deleted the ci/add_linter branch September 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandernorth alexandernorth alexandernorth approved these changes

@faebr faebr faebr approved these changes

@bruelea bruelea Awaiting requested review from bruelea

@jstudler jstudler Awaiting requested review from jstudler

Assignees

@henrybear327 henrybear327

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrybear327 @alexandernorth @faebr