Add linter CI pipeline

.github/workflows/govuln.yaml

@@ -19,4 +19,4 @@ jobs:
       - run: |
           set -euo pipefail
 
-          go install golang.org/x/vuln/cmd/govulncheck@latest && govulncheck ./...
+          make vulncheck

.github/workflows/lint.yaml

@@ -0,0 +1,60 @@
+---
+name: Static analysis
+on:
+  push:
+    branches:
+      - main
+    tags:
+      - v*
+  pull_request:
+permissions: read-all
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
+        with:
+          go-version: 1.22.6
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
+        with:
+          version: v1.60.3
+          args: --config tools/.golangci.yaml
+      - run: |
+          set -euo pipefail
+
+          make vet
+      - run: |
+          set -euo pipefail
+
+          make lint
+      - run: |
+          set -euo pipefail
+
+          make fmt
+
+          DIFF=$(git status --porcelain)
+
+          if [ -n "$DIFF" ]; then
+            echo "These files were modified:"
+            echo
+            echo "$DIFF"
+            echo
+            exit 1
+          fi
+      - run: |
+          set -euo pipefail
+
+          DIFF=$(git status --porcelain)
+
+          make generate manifests
+
+          if [ -n "$DIFF" ]; then
+          echo "These files were modified:"
+          echo
+          echo "$DIFF"
+          echo
+          echo "Please run make generate manifests and commit the changes."
+          exit 1
+          fi

Makefile

@@ -45,7 +45,7 @@ GO_PACKAGE_NAME_GOLANGCI_LINT := golangci-lint
 install-$(GO_PACKAGE_NAME_GOLANGCI_LINT):
 	@if [ ! -x "$(GOBIN)/$(GO_PACKAGE_NAME_GOLANGCI_LINT)" ]; then \
 		echo "Installing $(GO_PACKAGE_NAME_GOLANGCI_LINT)..." ; \
-		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOBIN) v1.57.2 ; \
+		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOBIN) v1.60.3 ; \
 	else \
 		echo "$(GO_PACKAGE_NAME_GOLANGCI_LINT) is installed" ; \
 	fi

internal/controller/expected_netboxmock_calls_test.go

@@ -1,5 +1,5 @@
 /*
-Copyright 2024.
+Copyright 2024 Swisscom (Schweiz) AG.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

internal/controller/netbox_testdata_test.go

@@ -1,5 +1,5 @@
 /*
-Copyright 2024.
+Copyright 2024 Swisscom (Schweiz) AG.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

internal/controller/suite_test.go

@@ -60,7 +60,6 @@ var ipamMockIpAddressClaim *mock_interfaces.MockIpamInterface
 var tenancyMock *mock_interfaces.MockTenancyInterface
 var ctx context.Context
 var cancel context.CancelFunc
-var netboxClient *api.NetboxClient
 
 func TestControllers(t *testing.T) {
 	RegisterFailHandler(Fail)

pkg/config/config.go

@@ -96,9 +96,8 @@ func GetOperatorConfig() *OperatorConfig {
 func GetProtocol() string {
 	if GetOperatorConfig().HttpsEnable {
 		return "https"
-	} else {
-		return "http"
 	}
+	return "http"
 }
 
 func GetBaseUrl() string {

tools/.golangci.yaml

@@ -5,9 +5,6 @@ issues:
   max-same-issues: 0
   exclude-files:
     - ^zz_generated.*
-    - test/
-    - pkg/leaselocker/
-    - internal/controller/suite_test.go
 linters:
   disable-all: true
   enable:
@@ -85,6 +82,3 @@ linters-settings:
       - name: error-strings
         severity: error
         disabled: false
-  # https://golangci-lint.run/usage/linters/#goheader
-  goheader:
-    template-path: ./tools/license_header.txt