Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert to table with multi primary or without autoicrement primary #105

Merged
merged 6 commits into from
Jan 26, 2017
Merged

Insert to table with multi primary or without autoicrement primary #105

merged 6 commits into from
Jan 26, 2017

Conversation

ricco24
Copy link
Contributor

@ricco24 ricco24 commented Oct 4, 2015

Insert to table without autoincrement primary or with multiple column primary returns inserted record.

I cant find bug1342.postgre but i think this solve this bug too. Maybe i can delete this bug report test file.

fixes #41 #80

@Unlink
Copy link
Contributor

Unlink commented Oct 8, 2015

Duplicate #102?
My PR also handles situations, where you have composite primary key and one part of it has autoincrement.
Try this:
https://github.com/nette/database/pull/102/files#diff-a5ef18703e35a05b08eb6089336ad773R21

@ricco24
Copy link
Contributor Author

ricco24 commented Oct 8, 2015

Yes, it is duplicate. I noticed your PR until after I made ​​my. So i let it here.
But this PR handles composite key with one autoincrement part too.

@dg
Copy link
Member

dg commented Oct 9, 2015

So ... which way to go? ;-)

@Unlink
Copy link
Contributor

Unlink commented Oct 9, 2015

@dg I'm not sure, i don't have completed API for IStructrure in my PR and i found there some issues.
so if @ricco24 adjusts them, i'll close my PR.

@dg dg force-pushed the master branch 11 times, most recently from 6ff42c6 to d46fee7 Compare January 26, 2017 01:59
@ricco24 ricco24 changed the base branch from master to v2.4 January 26, 2017 08:38
@ricco24 ricco24 changed the base branch from v2.4 to master January 26, 2017 08:38
@ricco24 ricco24 changed the base branch from master to v2.4 January 26, 2017 08:48
@ricco24
Copy link
Contributor Author

ricco24 commented Jan 26, 2017

@dg what with this? It is possible to merge or not? In current state nette database is unusable with php7.1, postgres 8.3+ and uuid as priamry key. Every insert fails ...

@dg
Copy link
Member

dg commented Jan 26, 2017

May this cause a BC break? (Except that it adds new method to interface.) Or is it suitable for 2.4?

@@ -1,4 +1,4 @@
/*!40102 SET storage_engine = InnoDB */;
/*!40102 SET default_storage_engine = InnoDB */;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about CREATE TABLE ... ENGINE=InnoDB as used in other files?

// Search for autoincrement key from multi primary key
if (is_array($primaryKey)) {
foreach ($this->getColumns($table) as $column) {
if (in_array($column['name'], $primaryKey) && $column['autoincrement']) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in_array() is relative slow operation, is possible this?

		if (is_array($primaryKey)) {
			$keys = array_flip($primaryKey);
			foreach ($this->getColumns($table) as $column) {
				if (isset($keys[$column['name']]) && $column['autoincrement']) {
					return $column['name'];
				}
			}
			return NULL;
		}

@dg
Copy link
Member

dg commented Jan 26, 2017

What about move searching for keys from getPrimaryAutoincrementKey (and maybe from getPrimaryKeySequence too) to loadStructure and use cache?

@ricco24
Copy link
Contributor Author

ricco24 commented Jan 26, 2017

That seems to be a good idea. I can make another pr with optimized loadStructure() function when this will be merged.

@dg
Copy link
Member

dg commented Jan 26, 2017

Ok, so I'll merge it. Thanks! 1f6133b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants