-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Track v1.4] New PR branch to serve as submodule for scikit-tree #53
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce the error on my local machine with following code:
from sklearn.ensemble import RandomForestClassifier
import numpy as np
from inspect import signature
rnd = np.random.RandomState(0)
n_samples = 30
X = rnd.uniform(size=(n_samples, 3))
y = np.arange(n_samples)
clf_1 = RandomForestClassifier()
clf_1.set_params(random_state=0)
func = getattr(clf_1, "fit", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
func = getattr(clf_1, "score", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
func = getattr(clf_1, "partial_fit", None)
func(X,y)
args = [p.name for p in signature(func).parameters.values()]
The code should replicate most of the check_fit_score_takes_y
test, but it runs smoothly every time. I also don't understand why only these 2 CIs failed when all should have the same test library.
- Linux_Runs pylatest_conda_forge_mkl
- macOS pylatest_conda_mkl_no_openmp
If you try running the |
@adam2392 Is |
Yeah it should be. The test is commented out tho rn. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CIs passed.
b2b36da
to
62f0c60
Compare
Signed-off-by: Adam Li <[email protected]>
62f0c60
to
ea330a7
Compare
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
TODO: Change
see: https://github.com/scikit-learn/scikit-learn/pull/27352/files and related PRs |
Signed-off-by: Adam Li <[email protected]>
This was accomplished in 9a5d91b |
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
…#30018) Co-authored-by: Lock file bot <[email protected]>
…30020) Co-authored-by: Lock file bot <[email protected]>
…ifierCV` (scikit-learn#29634) Co-authored-by: adrinjalali <[email protected]>
Co-authored-by: Lock file bot <[email protected]>
…earn#30017) Co-authored-by: Guillaume Lemaitre <[email protected]>
…earn#30014) Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
…ecate algorithm (scikit-learn#29997) Co-authored-by: Guillaume Lemaitre <[email protected]>
…cikit-learn#29996) Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
…30019) Co-authored-by: Lock file bot <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <[email protected]>
…eep_empty_features=True (scikit-learn#29779) Co-authored-by: Guillaume Lemaitre <[email protected]>
Reference Issues/PRs
As of v0.2 for sktree, we have decided we do not need a custom built and released via pypi scikit-learn fork. Instead, we just have to keep an updated fork branch here that maintains the changes under
tree/
andensemble/
.This branch has significantly lower diff and less complexity compared to e.g. #44
What does this implement/fix? Explain your changes.
Any other comments?