Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove esbuild + remove some any #61

Merged
merged 16 commits into from
Jan 19, 2023
Merged

fix: remove esbuild + remove some any #61

merged 16 commits into from
Jan 19, 2023

Conversation

ratik
Copy link
Collaborator

@ratik ratik commented Jan 12, 2023 •
edited by foxpy
Loading

As appeared esbuild has some weird issues with TS parsing: like this one

So replace esbuild with babel

https://github.com/neutron-org/neutron-tests/actions/runs/3903229531

@ratik ratik marked this pull request as ready for review January 12, 2023 12:15
sotnikov-s
sotnikov-s previously approved these changes Jan 12, 2023
View reviewed changes
foxpy
foxpy requested changes Jan 12, 2023
View reviewed changes
src/helpers/wait.ts Outdated Show resolved Hide resolved
@ratik ratik requested a review from foxpy January 12, 2023 13:02
sotnikov-s
sotnikov-s previously approved these changes Jan 12, 2023
View reviewed changes
sotnikov-s
sotnikov-s previously approved these changes Jan 12, 2023
View reviewed changes
albertandrejev
albertandrejev reviewed Jan 12, 2023
View reviewed changes
src/helpers/env.ts Outdated Show resolved Hide resolved
src/testcases/interchaintx.test.ts Show resolved Hide resolved
@ratik ratik changed the title fix: remove eslint + remove some any fix: remove esbuild + remove some any Jan 17, 2023
albertandrejev
albertandrejev previously approved these changes Jan 17, 2023
View reviewed changes
foxpy
foxpy previously approved these changes Jan 17, 2023
View reviewed changes
@ratik ratik requested a review from foxpy January 17, 2023 10:57
albertandrejev
albertandrejev previously approved these changes Jan 17, 2023
View reviewed changes
NeverHappened
NeverHappened previously approved these changes Jan 17, 2023
View reviewed changes
foxpy
foxpy previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ratik ratik requested a review from MrTalecky January 17, 2023 11:32
@ratik ratik mentioned this pull request Jan 17, 2023
Merged
foxpy
foxpy requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because this looks very bad.

src/helpers/cosmos.ts Outdated Show resolved Hide resolved
@ratik ratik force-pushed the feat/remove-esbuild-add-babel branch from 377b339 to 88bdd81 Compare January 19, 2023 11:50
@ratik ratik requested a review from foxpy January 19, 2023 12:21
foxpy
foxpy approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zavgorodnii zavgorodnii merged commit f2ffcfe into main Jan 19, 2023
@ratik ratik deleted the feat/remove-esbuild-add-babel branch January 19, 2023 13:32
@ratik ratik restored the feat/remove-esbuild-add-babel branch January 23, 2023 08:51
@ratik ratik mentioned this pull request Jan 23, 2023
Closed
@ratik ratik deleted the feat/remove-esbuild-add-babel branch March 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxpy foxpy foxpy approved these changes

@zavgorodnii zavgorodnii zavgorodnii approved these changes

@quasisamurai quasisamurai Awaiting requested review from quasisamurai

@lebedev42 lebedev42 Awaiting requested review from lebedev42

@sotnikov-s sotnikov-s Awaiting requested review from sotnikov-s

@MrTalecky MrTalecky Awaiting requested review from MrTalecky

@NeverHappened NeverHappened Awaiting requested review from NeverHappened

@albertandrejev albertandrejev Awaiting requested review from albertandrejev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ratik @NeverHappened @albertandrejev @zavgorodnii @foxpy @sotnikov-s