Update clade definitions #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous clades including 23B, 23C, ..., 23I are all now extinct or rare enough that extant examples are getting lumped into the "other" bin. With the current clade definitions these extinct clades are taking up all the color bandwidth and the three relevant clades of 24A, 24B and 24C are all similar shades of red. This commit removes extinct clades and updates colors for surviving clades.
joverlee521
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
LGTM, I assume the upcoming 24D clade will be added later as red?
jameshadfield
approved these changes
Sep 11, 2024
|
Thanks!
Yeah. As new clades get added (and old clades die out), we're going to need to keep manually updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous clades including 23B, 23C, ..., 23I are all now extinct or rare enough that extant examples are getting lumped into the "other" bin. With the current clade definitions these extinct clades are taking up all the color bandwidth and the three relevant clades of 24A, 24B and 24C are all similar shades of red.
This commit removes extinct clades and updates colors for surviving clades.
Clade frequencies on
mainClade frequencies with PR
Lineage growth advantages on
mainLineage growth advantages with PR
@joverlee521 or @jameshadfield, could you take a quick look at this?