-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.14 release: add support for traffic_policy
#862
Merged
Merged
+112
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TheConcierge
force-pushed
the
ryan/agent-release-traffic-policy
branch
from
July 26, 2024 22:28
e58be0b
to
83278e1
Compare
These are proposed docs changes for the agent release going out on Thursday |
russorat
reviewed
Jul 29, 2024
russorat
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. might need to also update the docs for the agent cli and config.
TheConcierge
force-pushed
the
ryan/agent-release-traffic-policy
branch
from
July 30, 2024 16:33
d469189
to
b0e4be7
Compare
TheConcierge
force-pushed
the
ryan/agent-release-traffic-policy
branch
2 times, most recently
from
August 1, 2024 16:31
862e745
to
d55bb88
Compare
TheConcierge
force-pushed
the
ryan/agent-release-traffic-policy
branch
from
August 1, 2024 17:18
7e2f474
to
fde0349
Compare
nijikokun
approved these changes
Aug 1, 2024
joelhans
added a commit
that referenced
this pull request
Aug 9, 2024
I noticed that after #862, some instances of example config files were changed from `policy` to `traffic_policy`, but that hadn't reached the Traffic Policy-specific doc ([example for HTTP](https://ngrok.com/docs/http/traffic-policy/?cty=agent-config)) for each type of endpoint. This PR updates those three examples to update the naming. And fixes what I believe to be malformed indentation in the TCP example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent has been updated to support sending policy as a string to the backend. This was added for both ephemeral tunnels and edge configurations with the API.
These changes are part of our ongoing effort to rename policy phases.