Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set random seed for opencv #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LexaNagiBator228
Copy link

You are using RANSAC based P3P for camera pose estimation. If you dont set random seed for opecv, the results are not reproducible, every time you run testing you get new results. With this small fix, your the testing is more stable.

@@ -73,7 +73,9 @@ int dsacstar_rgb_forward(
float maxReproj,
int subSampling)
{
ThreadRand::init();
// Set random seeds.
ThreadRand::init(42);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for consistency, I can remove it if you want

ThreadRand::init();
// Set random seeds.
ThreadRand::init(42);
cv::setRNGSeed(42);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix ransac results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant