Skip jq install if possible #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing 4 arguments trough multiple functions.
Instead of 2 parameters.
nirs
force-pushed
the
skip-jq-install
branch
from
a6b2303 to
5101cad
Compare
This minimize the time to start the VM in the CI, making it easier to debug startup issue, when we don't have ssh access to the guest. The time moves to the next step preparing the VM, but it is easier to debug that step with ssh access. Before: - start vm: 2m15s - prepare vm: 15s After: - start vm: 1m33s - prepare vm: 1m1s
nirs
force-pushed
the
skip-jq-install
branch
from
5101cad to
dda3b30
Compare
In the CI this completes now in 1m30s, so 3m is long enough to avoid flaky tests. Locally this takes less than 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minimize the time to start the VM in the CI, making it easier to debug startup issue, when we don't have ssh access to the guest. The time moves to the next step preparing the VM, but it is easier to debug.