Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log event ids introduced for important log statements #331

Merged
merged 147 commits into from
Oct 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
147 commits
Select commit Hold shift + click to select a range
05e817a
chore: update readme with TODO
tnotheis Oct 10, 2023
00caaf5
feat: add examples
tnotheis Oct 10, 2023
7612dab
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
06bc099
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
63a9bee
chore: added random event ids
NikolaVetnic Oct 11, 2023
f80e8b0
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
9dc7a6a
chore: supressed nullable warning
NikolaVetnic Oct 11, 2023
f608228
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
1830a4a
fix: updated event ids to unique values
NikolaVetnic Oct 11, 2023
2593143
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
80b6230
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
653ce33
chore: updated messages that only contain exception message
NikolaVetnic Oct 11, 2023
f47b890
feat: introduced log event ids
NikolaVetnic Oct 11, 2023
defd5e5
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
e300a4e
chore: removed unused directives
NikolaVetnic Oct 12, 2023
0b818de
chore: replaced generic codes with proper ones
NikolaVetnic Oct 12, 2023
5a2a165
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
e52ce1f
chore: both blob ids and names are now referred to as 'name' in all p…
NikolaVetnic Oct 12, 2023
471d376
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
c4083ef
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
fb6355f
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
cee99eb
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
049ba5b
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
745f0ae
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
2a20572
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
9045977
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
22a73e1
chore: updated log event names
NikolaVetnic Oct 12, 2023
0551bac
feat: introduced log event ids
NikolaVetnic Oct 12, 2023
a5bd780
chore: updated missing and redundant single quotes
NikolaVetnic Oct 12, 2023
0d01fdf
chore: removed unused directives
NikolaVetnic Oct 13, 2023
4328d15
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
b6878d8
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
721b314
chore: typos
NikolaVetnic Oct 13, 2023
f6e4859
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
2ad128b
chore: removed unused directives
NikolaVetnic Oct 13, 2023
67062a8
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
b9f8ede
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
c9a3a86
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
0d2c089
chore: typos
NikolaVetnic Oct 13, 2023
736a113
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
8d8e323
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
25599eb
chore: parameter name starting with upper case fix
NikolaVetnic Oct 13, 2023
ce191ee
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
7770f3a
fix: wrong method call
NikolaVetnic Oct 13, 2023
3ed939f
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
c97d92b
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
f80bd88
feat: introduced log event ids
NikolaVetnic Oct 13, 2023
704f8d0
feat: introdued log event ids
NikolaVetnic Oct 13, 2023
18b4deb
chore: removed the unused variable that caused the ci/cd test to fail
NikolaVetnic Oct 13, 2023
605e14e
Merge branch 'main' into introduce-log-event-ids
NikolaVetnic Oct 13, 2023
e708a89
feat: scripts for generating random event ids
NikolaVetnic Oct 13, 2023
0e395ee
Merge main into introduce-log-event-ids
github-actions[bot] Oct 13, 2023
1fece1f
Merge main into introduce-log-event-ids
github-actions[bot] Oct 16, 2023
75d2d72
fix: passing nameof(InfrastructureException) instead of whole exception
NikolaVetnic Oct 16, 2023
724c17a
chore: combined infrastructure, application and domain exceptions int…
NikolaVetnic Oct 16, 2023
d103ceb
chore: method renamed
NikolaVetnic Oct 16, 2023
8810978
chore: log event ids and names changed as per request
NikolaVetnic Oct 16, 2023
2f159e2
chore: log event names changed as per request
NikolaVetnic Oct 16, 2023
90b19f5
chore: log event name changed as per request
NikolaVetnic Oct 16, 2023
6be2b8a
chore: changes made as per requests
NikolaVetnic Oct 16, 2023
7a87294
chore: method names changed, log message changed
NikolaVetnic Oct 16, 2023
33efa54
fix: assigned unique event id
NikolaVetnic Oct 16, 2023
8dbadf3
chore: removed `handler` from event names for all handler classes' st…
NikolaVetnic Oct 16, 2023
b8fb91f
chore: naming updated as per request - `handler` not used, pattern `<…
NikolaVetnic Oct 16, 2023
70790d2
chore: updated line endings
NikolaVetnic Oct 16, 2023
2db44fe
chore: delegate names updated
NikolaVetnic Oct 16, 2023
d1a835f
chore: delegate and method names updated
NikolaVetnic Oct 16, 2023
a5cc404
chore: event names updated
NikolaVetnic Oct 16, 2023
3cc2bc8
chore: delegate name updated
NikolaVetnic Oct 16, 2023
d02d640
chore: delegate name updated
NikolaVetnic Oct 16, 2023
0394c13
Merge branch 'introduce-log-event-ids' of github.com:nmshd/backbone i…
NikolaVetnic Oct 16, 2023
32cac57
fix: \r\n replaced by \n in attempt to fix the error causing the form…
NikolaVetnic Oct 16, 2023
8dce016
Merge main into introduce-log-event-ids
github-actions[bot] Oct 17, 2023
0856b34
Merge main into introduce-log-event-ids
github-actions[bot] Oct 17, 2023
d1d84af
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
da18788
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
fd0d2dd
chore: partial class name change
NikolaVetnic Oct 18, 2023
b20fc3d
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
291b472
chore: formatting change
NikolaVetnic Oct 18, 2023
e322476
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
497de4c
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
f0bf73b
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
1b0b7e2
chore: internal class name change
NikolaVetnic Oct 18, 2023
d4da202
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
6864b3c
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
9a563ab
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
cf73218
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
a30886d
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
86d96d6
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
059468f
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
5c5ec18
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
9a0934c
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
3cf461a
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
d2fcb68
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
a8aa453
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
83bdfd2
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
56f51a2
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
2600069
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
5a602ad
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
5e5113c
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
1bd7943
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
d520f02
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
98a03c4
chore: refactoring log statements with id and name to use LoggerMessa…
NikolaVetnic Oct 18, 2023
9529d0e
Merge branch 'introduce-log-event-ids' of github.com:nmshd/backbone i…
NikolaVetnic Oct 18, 2023
6231467
Merge remote-tracking branch 'origin/main' into introduce-log-event-ids
NikolaVetnic Oct 18, 2023
aa1028c
Merge main into introduce-log-event-ids
github-actions[bot] Oct 18, 2023
b9fa051
Merge main into introduce-log-event-ids
github-actions[bot] Oct 18, 2023
2f083dd
Merge main into introduce-log-event-ids
github-actions[bot] Oct 18, 2023
ec71f33
chore: README updated with description on how to use the random numbe…
NikolaVetnic Oct 18, 2023
849a9d4
chore: logs defined as extension methods
NikolaVetnic Oct 18, 2023
2b775b0
Merge branch 'introduce-log-event-ids' of github.com:nmshd/backbone i…
NikolaVetnic Oct 18, 2023
e0f59f5
fix: after defining logs as extension methods some log statement call…
NikolaVetnic Oct 18, 2023
4af572c
chore: exception.ToString() replaced by nameof(exception) in logging …
NikolaVetnic Oct 18, 2023
bf7e6af
chore: remove comments
tnotheis Oct 18, 2023
a34ee48
chore: set log levels
tnotheis Oct 18, 2023
8e05498
chore: name passed to ErrorBlobWithNameExists method
NikolaVetnic Oct 19, 2023
6742082
chore: extension class renamed
NikolaVetnic Oct 19, 2023
e7f1ab6
chore: ILoggerExtensionsLogs refactored
NikolaVetnic Oct 19, 2023
bff1e55
chore: refactored the SaveChangesTimeInterceptor logs
NikolaVetnic Oct 19, 2023
3f7b34c
chore: messages refactored and method parameters renamed
NikolaVetnic Oct 19, 2023
37a1893
chore: method parameter renamed
NikolaVetnic Oct 19, 2023
43f993f
chore: method parameter renamed
NikolaVetnic Oct 19, 2023
2466a09
chore: method renamed and refactored
NikolaVetnic Oct 19, 2023
d9002a1
chore: method refactored to resemble the one in EventBusAzureServiceBus
NikolaVetnic Oct 19, 2023
65b7ba7
chore: method renamed and refactored
NikolaVetnic Oct 19, 2023
e556dd2
chore: method renamed and refactored
NikolaVetnic Oct 19, 2023
27788ef
chore: method renamed and refactored
NikolaVetnic Oct 19, 2023
b612f48
Merge branch 'introduce-log-event-ids' of github.com:nmshd/backbone i…
NikolaVetnic Oct 19, 2023
43f3b70
chore: substituted variables for classes as arguments of nameof() calls
NikolaVetnic Oct 19, 2023
ed17e19
chore: log level set dynamically instead of duplicating the methods
NikolaVetnic Oct 19, 2023
a628e19
chore: simplifying the logger messages
NikolaVetnic Oct 19, 2023
b41e2d0
chore: fixed a typo
NikolaVetnic Oct 19, 2023
d4f199a
fix: formatting issue that caused ci/cd test to fail
NikolaVetnic Oct 19, 2023
1ee3ffe
Merge remote-tracking branch 'origin/main' into introduce-log-event-ids
NikolaVetnic Oct 19, 2023
c135b48
chore: fix log event ids
tnotheis Oct 20, 2023
2d2285d
refactor: move identity quota commands to Identities folder
tnotheis Oct 20, 2023
e71339d
fix: compiler error
tnotheis Oct 20, 2023
5b519bd
chore: change remaining log event ids
tnotheis Oct 20, 2023
70c1ed6
chore: simplify linux script for event id generation
tnotheis Oct 20, 2023
67f70be
chore: rename scripts for generating log event ids
tnotheis Oct 20, 2023
8b8fa2f
fix: compiler errors
tnotheis Oct 20, 2023
9eb98fb
chore: fix formatting
tnotheis Oct 20, 2023
ebd8ef6
chore: use LoggerMessageAttribute
NikolaVetnic Oct 20, 2023
b071cdc
chore: use LoggerMessageAttribute
NikolaVetnic Oct 20, 2023
dc90dcd
chore: use LoggerMessageAttribute
NikolaVetnic Oct 20, 2023
6c3e15b
chore: use LoggerMessageAttribute
NikolaVetnic Oct 20, 2023
3f6914e
chore: fix event ids
tnotheis Oct 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: delegate name updated
NikolaVetnic committed Oct 16, 2023
commit d02d6408b664b66da97b729bbbe9f09d9523d91d
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ public async Task Handle(DeleteDeviceCommand request, CancellationToken cancella

file static class LoggerExtensions
{
private static readonly Action<ILogger, DeviceId, Exception> MARK_DEVICE_WITH_ID_AS_DELETED =
private static readonly Action<ILogger, DeviceId, Exception> MARKED_DEVICE_AS_DELETED =
LoggerMessage.Define<DeviceId>(
LogLevel.Information,
new EventId(776010, "Devices.MarkDeviceWithIdAsDeleted"),
@@ -55,6 +55,6 @@ file static class LoggerExtensions

public static void MarkDeviceWithIdAsDeleted(this ILogger logger, DeviceId deviceId)
{
MARK_DEVICE_WITH_ID_AS_DELETED(logger, deviceId, default!);
MARKED_DEVICE_AS_DELETED(logger, deviceId, default!);
}
}