Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhiMojo and UnphiMojo does not use cache #3708

Open
maxonfjvipon opened this issue Dec 19, 2024 · 4 comments
Open

PhiMojo and UnphiMojo does not use cache #3708

maxonfjvipon opened this issue Dec 19, 2024 · 4 comments
Labels
bug

Comments

@maxonfjvipon
Copy link
Member

If we run xmir-to-phi and phi-to-xmir a several times - new files are created every time. Let's make these mojos use cache
This was referenced Dec 25, 2024
Closed
Merged
Merged
Open
@ArtemGet
Copy link
Contributor

@maxonfjvipon Check referenced PRs, please. Caching logic mir-to-phi and phi-to-xmir would be included in next PRs.

@maxonfjvipon
Copy link
Member Author

@ArtemGet sure. Please note that we use Footprint class for caching, you can find examples of usage in other mojos

ArtemGet added a commit to ArtemGet/eo that referenced this issue Dec 30, 2024
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
57e7910 
…/tojos
ArtemGet added a commit to ArtemGet/eo that referenced this issue Jan 4, 2025
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
7348113 
…/tests-xmir-to-phi
ArtemGet added a commit to ArtemGet/eo that referenced this issue Jan 5, 2025
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
6749a63 
…/tests-phi-to-xmir

# Conflicts:
#	eo-maven-plugin/src/test/java/org/eolang/maven/PhiMojoTest.java
ArtemGet added a commit to ArtemGet/eo that referenced this issue Jan 8, 2025
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
a5e6a49 
…/tests-xmir-to-phi
ArtemGet added a commit to ArtemGet/eo that referenced this issue Jan 8, 2025
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
495edb1 
…/tests-phi-to-xmir
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@yegor256
Merge pull request #3776 from ArtemGet/bug/#3708/tests-phi-to-xmir
6466088 
Bug/#3708/tests for PhiMojo cache
@0pdd 0pdd mentioned this issue Jan 10, 2025
Open
@0pdd
Copy link

0pdd commented Jan 10, 2025

@maxonfjvipon the puzzle #3804 is still not solved.

ArtemGet added a commit to ArtemGet/eo that referenced this issue Jan 10, 2025
@ArtemGet
Merge remote-tracking branch 'origin/master' into bug/objectionary#3708…
ec613a9 
…/tests-xmir-to-phi
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@yegor256
Merge pull request #3777 from ArtemGet/bug/#3708/tests-xmir-to-phi
a762496 
bug(#3708): tests for UnphiMojo cache
@0pdd 0pdd mentioned this issue Jan 10, 2025
Open
@0pdd
Copy link

0pdd commented Jan 10, 2025

@maxonfjvipon 2 puzzles #3804, #3806 are still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0pdd @maxonfjvipon @ArtemGet