Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(#3708): Required tojo methods for caching xmir-to-phi/phi-to-xmir goals #3778

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

bug(#3708): Required tojo methods for caching xmir-to-phi/phi-to-xmir goals #3778

wants to merge 10 commits into from

Conversation

ArtemGet
Copy link
Contributor

Ref: #3708

@github-actions github-actions bot added the core label Dec 29, 2024
yegor256
yegor256 reviewed Dec 29, 2024
View reviewed changes
eo-maven-plugin/src/main/java/org/eolang/maven/Unplace.java Outdated
@@ -62,7 +86,7 @@ final class Unplace {
public String make(final Path file) {
return file.toString().substring(
this.parent.toString().length() + 1
).replaceAll(".eo$", "").replace(File.separator, ".");
).replaceAll(this.extension, "").replace(File.separator, ".");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtemGet this looks pretty dangerous. What if this.extension will be equal to ( -- you will get runtime exception here. Try using Pattern.quote().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 Agreed, add Pattern.quote and tests.

@maxonfjvipon
Copy link
Member

@ArtemGet please merge current master to your branch and restart the build

@ArtemGet
Copy link
Contributor Author

@maxonfjvipon Is OPTIMIZED attribute not present now? I am using it in xmir-to-phi cache.

@maxonfjvipon
Copy link
Member

@ArtemGet yes, it was removed here. Also please note that input directory for PhiMojo is 1-parse now, so you would need an XMIR attribute instead of OPTIMIZED

@github-actions github-actions bot removed the core label Dec 30, 2024
@ArtemGet
Copy link
Contributor Author

@maxonfjvipon Changed OPTIMIZED to XMIR. Could you check please?
Also, there is some Codacy check that fails on changing parsing/optimization directories(that is described wrongly, I guess) in eo-maven-plugin's README.

@ArtemGet ArtemGet mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegor256 yegor256 yegor256 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtemGet @maxonfjvipon @yegor256