-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use Picos for scheduler interop #136
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
change-to-use-picos
branch
4 times, most recently
from
October 2, 2023 17:34
a1ee8e0
to
f43c98d
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
5 times, most recently
from
October 24, 2023 12:18
fe7be98
to
62ed6e4
Compare
polytypic
changed the title
WIP: Change to use Picos for scheduler interop
Change to use Picos for scheduler interop
Oct 24, 2023
polytypic
force-pushed
the
change-to-use-picos
branch
from
October 24, 2023 12:28
62ed6e4
to
20d0905
Compare
polytypic
commented
Oct 24, 2023
kcas.opam.template
Outdated
@@ -1 +1,4 @@ | |||
doc: "https://ocaml-multicore.github.io/kcas/doc/kcas/Kcas/" | |||
pin-depends: [ | |||
[ "picos.dev" "git+https://github.com/ocaml-multicore/picos#2f2af8b2f170a38889211662fdc79bd160d82a69" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pin-depend must be removed before merging.
polytypic
commented
Oct 24, 2023
@@ -16,8 +16,7 @@ depends: [ | |||
"dune" {>= "3.8"} | |||
"ocaml" {>= "4.13.0"} | |||
"backoff" {>= "0.1.0"} | |||
"domain-local-await" {>= "1.0.0"} | |||
"domain-local-timeout" {>= "1.0.0"} | |||
"picos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should specify a version number.
polytypic
force-pushed
the
change-to-use-picos
branch
2 times, most recently
from
October 25, 2023 10:30
f33bd10
to
f3405ce
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
from
November 1, 2023 16:37
f3405ce
to
fec9ff3
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
12 times, most recently
from
December 9, 2023 21:15
fc4542e
to
82dd5b4
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
5 times, most recently
from
December 10, 2023 15:22
ffea3ef
to
3643595
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
3 times, most recently
from
December 22, 2023 20:15
4af4e1d
to
b0a362b
Compare
polytypic
force-pushed
the
change-to-use-picos
branch
from
December 22, 2023 21:53
b0a362b
to
74b2157
Compare
This has been replaced by work in #204. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Kcas to use Picos instead of DLA and DLT for scheduler interop.