Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 issue raised following the Rocky Linux 9 image upgrade #84

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jan 11, 2024

See https://github.com/ome/omero-metadata/actions/runs/7490016877/job/20387910739

I assume the new operating system is pulling a more recent of flake8 with additional warnings

@sbesson sbesson requested a review from jburel January 11, 2024 17:10
@jburel
Copy link
Member

jburel commented Jan 11, 2024

@sbesson I was working on branch on that upgrade. I have one test failure on my account. You were faster :-)

@jburel
Copy link
Member

jburel commented Jan 11, 2024

Same failure test_deletebulkanns

@sbesson
Copy link
Member Author

sbesson commented Jan 11, 2024

I won't have time to look into the other test failure today. Feel free to close this PR in favor of your branch

@jburel
Copy link
Member

jburel commented Jan 11, 2024

I am working on docker at the moment but will see if I can tonight

@sbesson
Copy link
Member Author

sbesson commented Jan 12, 2024

After additional debugging, the issue comes from the following log statements

INFO     omero.util.Resources:__init__.py:657 Starting
INFO     omero.util.Resources:__init__.py:680 Halted

i.e. there is no functional regression but it's surprising that these statements would be send to the stdout

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#369. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#370. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#371. See the console output for more details.
Possible conflicts:

--conflicts

@joshmoore
Copy link
Member

@dominikl @kkoz @will-moore: any opinions on what order these PRs should be merged? From my POV, this one could go in, but then everyone else will need to deal with the conflicts.

@dominikl
Copy link
Member

dominikl commented Jan 15, 2024

I closed my PR.

@will-moore
Copy link
Member

You can merge this first since there's only a couple of tiny conflicts with my PR, I can easily rebase and fix conflicts etc.

@jburel
Copy link
Member

jburel commented Jan 15, 2024

Thanks. So we can merge

@jburel jburel merged commit 358524c into ome:master Jan 15, 2024
1 check passed
@sbesson sbesson deleted the flake8 branch January 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants