-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flake8 issue raised following the Rocky Linux 9 image upgrade #84
Conversation
@sbesson I was working on branch on that upgrade. I have one test failure on my account. You were faster :-) |
Same failure |
I won't have time to look into the other test failure today. Feel free to close this PR in favor of your branch |
I am working on docker at the moment but will see if I can tonight |
After additional debugging, the issue comes from the following log statements
i.e. there is no functional regression but it's surprising that these statements would be send to the stdout |
Conflicting PR. Removed from build OMERO-plugins-push#369. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-plugins-push#370. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-plugins-push#371. See the console output for more details.
--conflicts |
@dominikl @kkoz @will-moore: any opinions on what order these PRs should be merged? From my POV, this one could go in, but then everyone else will need to deal with the conflicts. |
I closed my PR. |
You can merge this first since there's only a couple of tiny conflicts with my PR, I can easily rebase and fix conflicts etc. |
Thanks. So we can merge |
See https://github.com/ome/omero-metadata/actions/runs/7490016877/job/20387910739
I assume the new operating system is pulling a more recent of
flake8
with additional warnings