[L0] Refactoring of boolean event parameters #1600
Open
+90
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
reviewed
May 15, 2024
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
2 times, most recently
from
eafcd64 to
9679ead
Compare
nrspruit
reviewed
May 24, 2024
nrspruit
previously requested changes
May 24, 2024
pbalcer
reviewed
May 27, 2024
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
4d6f728 to
f18c41a
Compare
|
Hello @winstonzhang-intel , Please rebase since there are L0 CTS failures here: https://github.com/oneapi-src/unified-runtime/actions/runs/9651142091/job/26618341665?pr=1600. |
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
2 times, most recently
from
38b0489 to
e1d74f2
Compare
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Jul 11, 2024
PR in URT: oneapi-src/unified-runtime#1600 Signed-off-by: Winston Zhang <[email protected]>
pbalcer
force-pushed
the
event-bool-refactoring
branch
from
e1d74f2 to
dd16ed7
Compare
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
dd16ed7 to
4304208
Compare
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
4304208 to
4433ec8
Compare
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Sep 10, 2024
PR in URT: oneapi-src/unified-runtime#1600 Signed-off-by: Winston Zhang <[email protected]>
|
@winstonzhang-intel Please make sure that intel/llvm#14536 is updated and passing CI, so we could merge this. Thanks! |
|
I removed the ready to merge label temporarily until the intel/llvm side is updated and passing tests. Please readd it when intel/llvm PR is updated. |
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
4433ec8 to
9599d39
Compare
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Sep 18, 2024
PR in URT: oneapi-src/unified-runtime#1600 Signed-off-by: Winston Zhang <[email protected]>
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
9599d39 to
9d6d9bf
Compare
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
9d6d9bf to
689f323
Compare
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Sep 18, 2024
PR in URT: oneapi-src/unified-runtime#1600 Signed-off-by: Winston Zhang <[email protected]>
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
689f323 to
9d222e8
Compare
Working on rebasing against latest phase 2 of counterbased patch. |
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
9d222e8 to
97a49bf
Compare
winstonzhang-intel
added a commit
to winstonzhang-intel/llvm
that referenced
this pull request
Sep 19, 2024
PR in URT: oneapi-src/unified-runtime#1600 Signed-off-by: Winston Zhang <[email protected]>
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
97a49bf to
e10fb9b
Compare
|
@winstonzhang-intel , please resolve the merge conflicts with a rebase otherwise the changes look good. |
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
a5d77f4 to
2cae6db
Compare
This now includes the interrupt changes and is rebased on top of getEventCache changes. Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
event-bool-refactoring
branch
from
2cae6db to
0f1de75
Compare
Signed-off-by: Zhang, Winston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI in LLVM/SYCL: intel/llvm#14536