comparison against trixi via 2d advection

[pawelmagnu]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (3bc92c9) to head (907c0a6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[slayoo]

why do we need assert SETUP["nx"] == SETUP["ny"]?

[pawelmagnu]

the way converting vtu to numpy array works only supports square matrices

[slayoo]

let's then comment it with a GitHub issue URL!

[pawelmagnu]

i'll try to fix my code to support rectangular size

[slayoo]

the plot is not visible on GitHub in the notebook

[slayoo]

@pawelmagnu, it seems that the green "passes" of the notebook execution on Windows and macOS are actually silent failures. Adding some print statements results in no output. On macOS, the following is caught on stderr:

_ test_run_notebooks[examples/PyMPDATA_examples/advection_diffusion_2d/advection-diffusion-2d.ipynb] _
----------------------------- Captured stderr call -----------------------------
Assertion failed: false (src/object.cpp:438)

It would be best to replace in the notebook the "!" shell magics with Python subprocess execution including exit status checks to know if actually anything was executed and what was the status code.