-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comparison against trixi via 2d advection #454
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 30 30
Lines 1468 1468
=======================================
Hits 1351 1351
Misses 117 117 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need assert SETUP["nx"] == SETUP["ny"]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way converting vtu to numpy array works only supports square matrices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's then comment it with a GitHub issue URL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll try to fix my code to support rectangular size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plot is not visible on GitHub in the notebook
@pawelmagnu, it seems that the green "passes" of the notebook execution on Windows and macOS are actually silent failures. Adding some print statements results in no output. On macOS, the following is caught on stderr:
It would be best to replace in the notebook the "!" shell magics with Python subprocess execution including exit status checks to know if actually anything was executed and what was the status code. |
No description provided.