-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comparison against trixi via 2d advection #454
Open
pawelmagnu
wants to merge
27
commits into
open-atmos:main
Choose a base branch
from
pawelmagnu:trixi_comparison
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
9c38b9b
init commit
pawelmagnu 4ced6f2
comparison against trixi in 2d advection
pawelmagnu bad68c2
add meshio to workflow
pawelmagnu 6ad8e93
add imegeio to workflow
pawelmagnu e335216
solution path fix
pawelmagnu 24e299c
pylint
pawelmagnu cce03cb
more verbose exception
pawelmagnu 4d0c56a
more verbose exception, fix output file path
pawelmagnu 76a0328
more verbose exception, fix output file path
pawelmagnu 2ad7990
path to solution fix
pawelmagnu a6a9c6f
path to solution fix; tmax fix
pawelmagnu 9943188
move omega and min max coordinates to config
pawelmagnu 0ab0152
update tests to main
pawelmagnu 5d13afa
update tests to main 2
pawelmagnu cdd3d5a
Update tests+pypi.yml
pawelmagnu 4cc0d4d
Merge branch 'open-atmos:main' into trixi_comparison
pawelmagnu 496bd36
Merge branch 'open-atmos:main' into trixi_comparison
pawelmagnu 1448102
Merge branch 'open-atmos:main' into trixi_comparison
pawelmagnu b5812d9
add explanation on the examples; changed paths to outputs
pawelmagnu d9e1e69
add Julia setup step
slayoo 47d9443
add debug statement
slayoo c36f7e6
add debug flags to pytest
slayoo 24b208d
one more debug statement
slayoo 4438781
change pytest flag
slayoo 6a4e76e
add subprocesses to julia code
pawelmagnu 8aee59a
Merge branch 'open-atmos:main' into trixi_comparison
pawelmagnu 907c0a6
add more debug info to notebook
pawelmagnu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
627 changes: 627 additions & 0 deletions
627
examples/PyMPDATA_examples/trixi_comparison/advection_comparison.ipynb
pawelmagnu marked this conversation as resolved.
Show resolved
Hide resolved
pawelmagnu marked this conversation as resolved.
Show resolved
Hide resolved
pawelmagnu marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the plot is not visible on GitHub in the notebook |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need
assert SETUP["nx"] == SETUP["ny"]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way converting vtu to numpy array works only supports square matrices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's then comment it with a GitHub issue URL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll try to fix my code to support rectangular size