Socket updates - reconnect loop, merge buttons #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed formatting - Removed all `ScopedPointer`s and used std::unique_ptr instead
- Say the remote socket closes unexpectedly; now, this plugin will attempt to automatically reconnect to the same port if the remote socket opens again - This will also ensure that header parameters are consistent between connections, and will stop acquisition if the header changes
bparks13
force-pushed
the
testing-juce8
branch
from
dc15cb2
to
87d053a
Compare
bparks13
force-pushed
the
testing-juce8
branch
from
87d053a
to
d5a1f6d
Compare
- Once connected, all data is read to prevent buffer overflow - If acquisition is running, this data is processed and plotted; otherwise, it is thrown away Fixes #12
jonnew
reviewed
Nov 4, 2024
- Fixed a visual bug where the disconnect button would not be correctly enabled in certain conditions
jonnew
reviewed
Nov 4, 2024
Source/Socket.cpp
Outdated
| if (printOutput) | ||
| { | ||
| LOGC("EphysSocket failed to connect; could not read header from stream."); | ||
| CoreServices::sendStatusMessage("Ephys Socket: Could not read stream."); |
There was a problem hiding this comment.
Putting here for lack of better place:
I think the messages presented in the GUI should be more descriptive. For instance, when I change the underlying type of a cv::Mat in Bonsai, I get the following error message
It would be nice if the message said why the Ephys Socket stopped data acqusition (in this case I changed for u16 to floats). I would say the same is true for e.g. changing the shape of the input array. I would be nice to know what exactly. I see this in the console
[open-ephys][debug] CoreServices::sendStatusMessage: Ephys Socket: Invalid header
[open-ephys] ***ERROR*** Ephys Socket: Header values have changed since first connecting
But, this still does not tell us what changed that caused the issue and its quite buried to the user. I think this info should be displayed on the main message bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updated to work with version 1.0 of the GUI.
If the remote socket closes unexpectedly, the plugin will attempt to automatically reconnect to the same port if the remote socket opens again.
This will also ensure that header parameters are consistent between connections, and will stop acquisition if the header changes.
Buttons are consolidated so there is one button that changes from
ConnecttoDisconnectand vice versa.