Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Next.js 13 #659

Closed
rohansx opened this issue Jun 23, 2023 · 62 comments
Closed

Migrate to Next.js 13 #659

rohansx opened this issue Jun 23, 2023 · 62 comments
Assignees
Labels
enhancement New feature or request gssoc23 This label is for GirlScript summer of code help wanted Extra attention is needed level3 Difficult issues

Comments

@rohansx
Copy link
Collaborator

rohansx commented Jun 23, 2023

Checkout discussion #660

@github-actions
Copy link

Hello rohansx, thanks for opening a issue, your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

@rohansx rohansx pinned this issue Jun 23, 2023
@rohansx rohansx added enhancement New feature or request help wanted Extra attention is needed gssoc23 This label is for GirlScript summer of code labels Jun 23, 2023
@crocmons
Copy link
Collaborator

crocmons commented Jun 23, 2023

Recently I learned Next.js 13 & do some projects on that...I would love to do this so that my skills will be enhanced..Can you assign this issue to me as a GSSOC23 contributor?
Screenshot (442)

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 24, 2023

@crocmons have u gone through discussion #660

@crocmons
Copy link
Collaborator

@crocmons have u gone through discussion #660

yeah..I read it properly..

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 24, 2023

@crocmons so are u planning to migrate it in one go?

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 24, 2023

@crocmons How long will it take for you to successfully migrate this?

@crocmons
Copy link
Collaborator

@crocmons so are u planning to migrate it in one go?

yeah, I guess I need 1 week to successfully migrate this code into next.js 13...and if I have any trouble migrating this code then I will tell you...

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 25, 2023

Ok then, go ahead

@rohansx rohansx added the level3 Difficult issues label Jun 25, 2023
@s2sharpit
Copy link
Member

s2sharpit commented Jun 27, 2023

Hello there,

I'm interested in collaborating to migrate the website to Next.js. I have extensive experience in building websites with Next.js, some of which include B. S. Sen. Sec. School and my portfolio s2sharpit.me.

@rohansx @crocmons, I would be grateful for the opportunity to collaborate with you on this project. Can I join in?

Looking forward to your response!

धन्यवाद

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 28, 2023

@s2sharpit yes you can collaborate with @crocmons if is she needs any assistance.
@crocmons Do you want to collaborate with him?

@s2sharpit
Copy link
Member

Hey @crocmons,

Looking forward to your response!

@crocmons
Copy link
Collaborator

@rohansx @s2sharpit Yeah, sure, why not it's a great way to learn...

@rohansx
Copy link
Collaborator Author

rohansx commented Jun 29, 2023

OK then you guys can work for this issue together. @s2sharpit You can take css part which needs to be migrated into tailwind css. Is that ok or something else you want to work on?

@s2sharpit
Copy link
Member

s2sharpit commented Jun 30, 2023

Hi @crocmons,

I hope you're doing well. I wanted to reach out and let you know that I've just created a new branch called next-ts-tw-migrate for our ongoing migration process. It would be fantastic if you could assist me by creating a pull request and incorporating the code for the Next.js migration that has been completed thus far into this branch, and, If you encounter any problems or difficulties during the process, let me know.

Your expertise and collaboration would be greatly appreciated. Thank you so much for your support!

@crocmons
Copy link
Collaborator

Hi @crocmons,

I hope you're doing well. I wanted to reach out and let you know that I've just created a new branch called next-ts-tw-migrate for our ongoing migration process. It would be fantastic if you could assist me by creating a pull request and incorporating the code for the Next.js migration that has been completed thus far into this branch, and, If you encounter any problems or difficulties during the process, let me know.

Your expertise and collaboration would be greatly appreciated. Thank you so much for your support!

ok

@s2sharpit
Copy link
Member

s2sharpit commented Jun 30, 2023

Hey @crocmons
Are you facing any problems while creating the pull request?

@crocmons
Copy link
Collaborator

Actually, I need some time to work on it.. @s2sharpit I haven't created the pull request yet... @rohansx can you extend the time duration of this issue? Because I started today & there is a lot of code I have to remove also modify the code structure...

@s2sharpit
Copy link
Member

s2sharpit commented Jun 30, 2023

Actually, I need some time to work on it.. @s2sharpit I haven't created the pull request yet... @rohansx can you extend the time duration of this issue? Because I started today & there is a lot of code I have to remove also modify the code structure...

Hey @crocmons ,
I completely understand that it can be a complex task, and I appreciate your efforts so far. Please don't feel rushed, as I understand that removing and modifying code, as well as setting up files for Next.js and TypeScript, requires careful consideration and effort.

Just to clarify, I'm not expecting the entire migration to be completed immediately. My suggestion is to create a pull request for the part that has been done so far, or even set up the initial Next.js and TypeScript configuration. From there, we can gradually add the rest of the code to the new branch as we make progress.

Additionally, if you're not comfortable creating the starting files for Next.js and TypeScript, I'd be more than happy to handle that part. Just let me know, and I can take care of it. We want to ensure a smooth transition, and I'm here to support you in any way I can.

I'd like to add that creating a separate branch and adding the files to it will greatly help our collaborators(like me) understand the progress made and who is working on which part. It will provide transparency and facilitate smoother collaboration within the team.

If you encounter any challenges or need any assistance during the process, feel free to reach out. Let's collaborate on this together and take the necessary time to ensure a successful migration.

Thanks again for your dedication to this project, and I look forward to working with you on the pull request.

@crocmons
Copy link
Collaborator

crocmons commented Jun 30, 2023

Actually, I need some time to work on it.. @s2sharpit I haven't created the pull request yet... @rohansx can you extend the time duration of this issue? Because I started today & there is a lot of code I have to remove also modify the code structure...

Hey, It's not to do whole migration today. It's just to create a pull request for the part you have done yet or the starting files.

Ohh yeah, I got it. Let me create then..

@crocmons
Copy link
Collaborator

crocmons commented Jun 30, 2023

wait @s2sharpit typescript.. we don't need to add typescript here? In discussion #660 not mentioned typescript. Please read it properly.. Tomorrow I'll give you the pr so that you can work on this issue..

@s2sharpit
Copy link
Member

Hey @crocmons
Can you tell me what error are you getting?

@crocmons
Copy link
Collaborator

crocmons commented Jul 1, 2023

yeah, @s2sharpit I'm getting errors on that branch now it was fixed ..And Also I create a pr but not completed yet still need to work on it...

@crocmons
Copy link
Collaborator

@rohansx, I think the 'next-ts-tw-migrate' branch is almost done. So, you can merge it into the main branch. We will do the rest of the implementation on the main branch so that other contributors can continue their work with this newly developed branch.

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 23, 2023

@s2sharpit @crocmons I saw by running the code of the nextjs branch, and its design has changed significantly from the main branch, including changes to the home page and other pages as well. So, please take a look at it once by comparing with the main branch deployed link

@s2sharpit
Copy link
Member

@s2sharpit @crocmons I saw by running the code of the nextjs branch, and its design has changed significantly from the main branch, including changes to the home page and other pages as well. So, please take a look at it once by comparing with the main branch deployed link

Thank you, @rohansx, for taking the time to explore the nextjs branch! Our goal was to improve the website, so we resolved any identified UI issues and made it more attractive where we felt it needs improvement. The ultimate aim was to create a seamless and enjoyable website. We would greatly appreciate your valuable feedback or any suggestions you might have for further improvement. Your input is essential to us, and we look forward to hearing from you!

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 26, 2023

@s2sharpit @crocmons I was facing issues with the process you mentioned, so I created a copy of the main branch and named it 'v1.' Then, I copied all the files from the 'next-js-tw-migrate' branch and overwrote the files in the 'main' branch. After that, I pushed the changes to the main branch.

The migration to Next.js has been successfully completed in the main branch.

Apologies for the delays, now you can proceed with the further process and issues. Thanks for helping throughout this open source program. You guys are great contributors and collaborators. Appreciate your contributions.

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 26, 2023

@s2sharpit @crocmons Now, there is a main task to be done, which is to integrate the open-source book reader platform with books in the format of pdf or epub. Let me know if you guys would like to take on this task.

@s2sharpit
Copy link
Member

@s2sharpit @crocmons I was facing issues with the process you mentioned, so I created a copy of the main branch and named it 'v1.' Then, I copied all the files from the 'next-js-tw-migrate' branch and overwrote the files in the 'main' branch. After that, I pushed the changes to the main branch.

The migration to Next.js has been successfully completed in the main branch.

Apologies for the delays, now you can proceed with the further process and issues. Thanks for helping throughout this open source program. You guys are great contributors and collaborators. Appreciate your contributions.

Fantastic news, @rohansx! Thank you for the kind words and for all your assistance. Just a quick heads up, we'll need to update the framework preset in Vercel. Let's get that done and continue with the process. Appreciate your continued support.

Screenshot (495)

@s2sharpit
Copy link
Member

@s2sharpit @crocmons Now, there is a main task to be done, which is to integrate the open-source book reader platform with books in the format of pdf or epub. Let me know if you guys would like to take on this task.

Hey @rohansx,

Thanks for reaching out! I'm interested in contributing to the project, but I must admit that I'm not familiar with integrating a book reader platform. However, I'm eager to learn and take on new challenges. I'll quickly look into it and get back to you soon to confirm if I can handle the task. Thanks again for considering me for this opportunity.

Looking forward to your response!

Best regards,
Tushar ☺️

@s2sharpit
Copy link
Member

@s2sharpit @crocmons I was facing issues with the process you mentioned, so I created a copy of the main branch and named it 'v1.' Then, I copied all the files from the 'next-js-tw-migrate' branch and overwrote the files in the 'main' branch. After that, I pushed the changes to the main branch.

The migration to Next.js has been successfully completed in the main branch.

Apologies for the delays, now you can proceed with the further process and issues. Thanks for helping throughout this open source program. You guys are great contributors and collaborators. Appreciate your contributions.

I have checked it locally. It's working perfectly. 👍☺️❤️

@crocmons
Copy link
Collaborator

Dear @rohansx,

I am happy to inform you that the issue has been resolved by adding the Mongodb environment key. Everything is now working correctly. Please be reminded to add your MongoDB environment key and ensure that the DB name is "Books".

Thank you for your cooperation.

Screenshot (510)

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 27, 2023

@s2sharpit @crocmons Thanks for your help. I deployed the project but books section is not visible on homepage please check that

@crocmons
Copy link
Collaborator

Could you kindly provide the link here, @rohansx?

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 27, 2023

Could you kindly provide the link here, @rohansx?

It's the same link.. www.informatician.in

@s2sharpit
Copy link
Member

Could you kindly provide the link here, @rohansx?

@crocmons, Are you working on it, or I address this issue?

@rohansx
Copy link
Collaborator Author

rohansx commented Jul 27, 2023

Also I have deployed the v1 branch on https://react.informatician.in for taking reference to make further changes like adding oauth in login section and many more

@crocmons
Copy link
Collaborator

crocmons commented Jul 27, 2023

It appears that you have previously worked on this homepage, so I believe you may be able to address the issue at hand. Is it possible that the problem is related to the react-swiper card? @s2sharpit

@s2sharpit
Copy link
Member

It appears that you have previously worked on this homepage, so I believe you may be able to address the issue at hand. Is it possible that the problem is related to the react-swiper card? @s2sharpit

It was working perfectly at morning. Let me handle the issue then. ☺️

@crocmons
Copy link
Collaborator

Also, @s2sharpit I got this warning on my terminal you can check it out-

Warning: ReactStars: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
at ReactStars (webpack-internal:///(sc_client)/./node_modules/react-rating-stars-component/dist/react-stars.js:41:41)
at div
at div
at div
at CardContent (webpack-internal:///(sc_client)/./components/BkCards/CardContent/CardContent.js:41:28)
at a
at LinkComponent (webpack-internal:///(sc_client)/./node_modules/next/dist/client/link.js:105:19)
at div
at eval (webpack-internal:///(sc_client)/./node_modules/swiper/react/swiper-slide.js:26:67)
at div
at div
at eval (webpack-internal:///(sc_client)/./node_modules/swiper/react/swiper.js:40:98)
at div
at div
at div
at div
at BkCards (webpack-internal:///(sc_client)/./components/BkCards/BkCards.js:51:69)
at Lazy
at div
at section
at InnerLayoutRouter (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/layout-router.js:226:11)
at RedirectErrorBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/redirect-boundary.js:72:9)
at RedirectBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/redirect-boundary.js:80:11)
at NotFoundBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/not-found-boundary.js:59:11)
at LoadingBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/layout-router.js:322:11)
at ErrorBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/error-boundary.js:103:11)
at InnerScrollAndFocusHandler (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/layout-router.js:139:9)
at ScrollAndFocusHandler (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/layout-router.js:213:11)
at RenderFromTemplateContext (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/render-from-template-context.js:15:44)
at Lazy
at OuterLayoutRouter (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/layout-router.js:331:11)
at Lazy
at m (webpack-internal:///(sc_client)/./node_modules/next-themes/dist/index.js:1:335)
at exports.ThemeProvider (webpack-internal:///(sc_client)/./node_modules/next-themes/dist/index.js:1:3636)
at ThemeProvider (webpack-internal:///(sc_client)/./components/theme/theme-provider.jsx:13:26)
at Lazy
at body
at html
at RedirectErrorBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/redirect-boundary.js:72:9)
at RedirectBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/redirect-boundary.js:80:11)
at ReactDevOverlay (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/react-dev-overlay/internal/ReactDevOverlay.js:70:9)
at NotFoundErrorBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/not-found-boundary.js:51:9)
at NotFoundBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/not-found-boundary.js:59:11)
at HotReload (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/react-dev-overlay/hot-reloader-client.js:319:11)
at Router (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/app-router.js:147:11) at ErrorBoundaryHandler (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/error-boundary.js:77:9)
at ErrorBoundary (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/error-boundary.js:103:11)
at AppRouter (webpack-internal:///(sc_client)/./node_modules/next/dist/client/components/app-router.js:384:13)
at Lazy
at Lazy
at ServerComponentWrapper (C:\Users\HP\informatician-2\node_modules\next\dist\server\app-render\create-server-components-renderer.js:90:31)
at ServerComponentWrapper (C:\Users\HP\informatician-2\node_modules\next\dist\server\app-render\create-server-components-renderer.js:90:31)
at InsertedHTML (C:\Users\HP\informatician-2\node_modules\next\dist\server\app-render\app-render.js:890:33)

@s2sharpit
Copy link
Member

s2sharpit commented Jul 27, 2023

Also, @s2sharpit I got this warning on my terminal you can check it out-

Yaa, I got the error. Fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc23 This label is for GirlScript summer of code help wanted Extra attention is needed level3 Difficult issues
Projects
None yet
Development

No branches or pull requests

4 participants