-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Next.js 13 #659
Comments
Hello rohansx, thanks for opening a issue, your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible. |
@crocmons so are u planning to migrate it in one go? |
@crocmons How long will it take for you to successfully migrate this? |
yeah, I guess I need 1 week to successfully migrate this code into next.js 13...and if I have any trouble migrating this code then I will tell you... |
Ok then, go ahead |
Hello there, I'm interested in collaborating to migrate the website to Next.js. I have extensive experience in building websites with Next.js, some of which include B. S. Sen. Sec. School and my portfolio s2sharpit.me. @rohansx @crocmons, I would be grateful for the opportunity to collaborate with you on this project. Can I join in? Looking forward to your response! धन्यवाद |
@s2sharpit yes you can collaborate with @crocmons if is she needs any assistance. |
Hey @crocmons, Looking forward to your response! |
@rohansx @s2sharpit Yeah, sure, why not it's a great way to learn... |
OK then you guys can work for this issue together. @s2sharpit You can take css part which needs to be migrated into tailwind css. Is that ok or something else you want to work on? |
Hi @crocmons, I hope you're doing well. I wanted to reach out and let you know that I've just created a new branch called next-ts-tw-migrate for our ongoing migration process. It would be fantastic if you could assist me by creating a pull request and incorporating the code for the Next.js migration that has been completed thus far into this branch, and, If you encounter any problems or difficulties during the process, let me know. Your expertise and collaboration would be greatly appreciated. Thank you so much for your support! |
ok |
Hey @crocmons |
Actually, I need some time to work on it.. @s2sharpit I haven't created the pull request yet... @rohansx can you extend the time duration of this issue? Because I started today & there is a lot of code I have to remove also modify the code structure... |
Hey @crocmons , Just to clarify, I'm not expecting the entire migration to be completed immediately. My suggestion is to create a pull request for the part that has been done so far, or even set up the initial Next.js and TypeScript configuration. From there, we can gradually add the rest of the code to the new branch as we make progress. Additionally, if you're not comfortable creating the starting files for Next.js and TypeScript, I'd be more than happy to handle that part. Just let me know, and I can take care of it. We want to ensure a smooth transition, and I'm here to support you in any way I can. I'd like to add that creating a separate branch and adding the files to it will greatly help our collaborators(like me) understand the progress made and who is working on which part. It will provide transparency and facilitate smoother collaboration within the team. If you encounter any challenges or need any assistance during the process, feel free to reach out. Let's collaborate on this together and take the necessary time to ensure a successful migration. Thanks again for your dedication to this project, and I look forward to working with you on the pull request. |
Ohh yeah, I got it. Let me create then.. |
wait @s2sharpit typescript.. we don't need to add typescript here? In discussion #660 not mentioned typescript. Please read it properly.. Tomorrow I'll give you the pr so that you can work on this issue.. |
Hey @crocmons |
yeah, @s2sharpit I'm getting errors on that branch now it was fixed ..And Also I create a pr but not completed yet still need to work on it... |
@rohansx, I think the 'next-ts-tw-migrate' branch is almost done. So, you can merge it into the main branch. We will do the rest of the implementation on the main branch so that other contributors can continue their work with this newly developed branch. |
@s2sharpit @crocmons I saw by running the code of the nextjs branch, and its design has changed significantly from the main branch, including changes to the home page and other pages as well. So, please take a look at it once by comparing with the main branch deployed link |
Thank you, @rohansx, for taking the time to explore the nextjs branch! Our goal was to improve the website, so we resolved any identified UI issues and made it more attractive where we felt it needs improvement. The ultimate aim was to create a seamless and enjoyable website. We would greatly appreciate your valuable feedback or any suggestions you might have for further improvement. Your input is essential to us, and we look forward to hearing from you! |
@s2sharpit @crocmons I was facing issues with the process you mentioned, so I created a copy of the main branch and named it 'v1.' Then, I copied all the files from the 'next-js-tw-migrate' branch and overwrote the files in the 'main' branch. After that, I pushed the changes to the main branch. The migration to Next.js has been successfully completed in the main branch. Apologies for the delays, now you can proceed with the further process and issues. Thanks for helping throughout this open source program. You guys are great contributors and collaborators. Appreciate your contributions. |
@s2sharpit @crocmons Now, there is a main task to be done, which is to integrate the open-source book reader platform with books in the format of pdf or epub. Let me know if you guys would like to take on this task. |
Fantastic news, @rohansx! Thank you for the kind words and for all your assistance. Just a quick heads up, we'll need to update the framework preset in Vercel. Let's get that done and continue with the process. Appreciate your continued support. |
Hey @rohansx, Thanks for reaching out! I'm interested in contributing to the project, but I must admit that I'm not familiar with integrating a book reader platform. However, I'm eager to learn and take on new challenges. I'll quickly look into it and get back to you soon to confirm if I can handle the task. Thanks again for considering me for this opportunity. Looking forward to your response! Best regards, |
I have checked it locally. It's working perfectly. 👍 |
Dear @rohansx, I am happy to inform you that the issue has been resolved by adding the Mongodb environment key. Everything is now working correctly. Please be reminded to add your MongoDB environment key and ensure that the DB name is "Books". Thank you for your cooperation. |
@s2sharpit @crocmons Thanks for your help. I deployed the project but books section is not visible on homepage please check that |
Could you kindly provide the link here, @rohansx? |
It's the same link.. www.informatician.in |
Also I have deployed the v1 branch on https://react.informatician.in for taking reference to make further changes like adding oauth in login section and many more |
It appears that you have previously worked on this homepage, so I believe you may be able to address the issue at hand. Is it possible that the problem is related to the react-swiper card? @s2sharpit |
It was working perfectly at morning. Let me handle the issue then. |
Also, @s2sharpit I got this warning on my terminal you can check it out- Warning: ReactStars: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. |
Yaa, I got the error. Fixing it. |
Checkout discussion #660
The text was updated successfully, but these errors were encountered: