Add Region MVars #94
Closed
Add Region MVars #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 946b665.
After running `simp_peephole[add, rgn]`, the proof state changes to:
--
application type mismatch
HVector.denote
(_ :
∀ (h : Ctxt.get? (Ctxt.snoc ?m.641463 ?m.641464) 0 = some ?m.641464),
{ val := 0, property := h } = Var.last ?m.641463 ?m.641464)
argument
Var.zero_eq_last
has type
∀ (h : Ctxt.get? (Ctxt.snoc ?m.641463 ?m.641464) 0 = some ?m.641464),
{ val := 0, property := h } = Var.last ?m.641463 ?m.641464 : Prop
but is expected to have type
HVector (fun t => Reg ?m.641456 t.fst t.snd) ?m.641461 : Type
--
bollu
reviewed
Sep 21, 2023
| intros a | ||
| -- | @chris: what's the correct lemma we need | ||
| -- to automate this proof? | ||
| simp[Ctxt.Valuation.snoc] |
There was a problem hiding this comment.
What's the correct simp lemma instead of this? The proof state is:
Ctxt.Valuation.snoc ll✝ ((fun val => mv✝ [ExTy.nat] ExTy.nat 0 fun _ty _var => val)^[0] a)
(Var.last [ExTy.nat] ExTy.nat) =
a
|
@ChrisHughes24 The fact that |
|
I'm going to close this, since I believe development on this line of proof strategy has halted for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are people happy with this implementation of regions and region MVars before I work on it further?