Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for Events V2 to match Events V1 more closely #8805

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Minor fixes for Events V2 to match Events V1 more closely #8805

wants to merge 3 commits into from

Conversation

Keksike
Copy link
Contributor

@Keksike Keksike commented Feb 27, 2025 •
edited
Loading

Related to farajaland e2e testing pr: opencrvs/opencrvs-farajaland#1250

  • Remove logic for changing the text of last form page continue button
  • Add matching id attribute to header new event button
  • Switch event toggle menu id

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Keksike Keksike mentioned this pull request Feb 28, 2025
Open
@Keksike Keksike marked this pull request as ready for review February 28, 2025 08:52
@rikukissa rikukissa added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keksike @rikukissa