Feat/use dynamic harvest field #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could also store it as isoformat (it was previously the case for last_update). However, we'll need to manipulate dates a bit more with additional created_at and last_modified fields.
Fixture order did not work as I expected, being not-deterministic
quaxsze
approved these changes
Oct 11, 2022
abulte
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Looks nice, big work 👏 Code is much easier to read.
Really not sure about that dct_identifier thing...
NB: empty file here https://github.com/opendatateam/udata/pull/2762/files#diff-1a11729151284ff74f2c7d1cbec38f0e8960a87758b4c755bf3f9d612722cfce, maybe remove?
maudetes
commented
Nov 4, 2022
maudetes
commented
Nov 4, 2022
The entire job now fails at initlization time if any of the dataset has a DCT.identifier missing
abulte
reviewed
Nov 8, 2022
abulte
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix datagouv/data.gouv.fr#818, alternative to #2750
Uses a separate
harvestdynamic document to store harvest information.The core fields are defined in /dataset/models.py.
Any entry can be added freely, without validation however.
Add a migration (around 15min locally) to move harvest metadata.
Explicit api field definition is needed for core or any additional fields to expose it by api. See https://github.com/maudetes/udata/blob/67dfdda59750eb4224c07b1da4c792f41147a26f/udata/core/dataset/api_fields.py#L22 for fields defined in udata core.
Other entries would be added by modifying this field definition, ex in udata-ods:
Harvest dates are now stored in the harvest metadata and don't override the object dates.
Thus, we should iterate to return the correct dates on the frontend (ex: max between mongo object & harvest metadata?).
The exhausting list of dataset extras that have been migrated to harvest metadata is:
odsandckan-prefixed extras)TODO
Some defined fields could be replaced or merged? Ex: dct_identifier is the same as remote_id for dcat harvested datasets. Are these values needed? Made a first attempt at removing those: maudetes@a5a6d97.-> We keep these for now, see Feat/use dynamic harvest field #2762 (comment)