docs(performance-tips): added steps to deploy io engine deamonset #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AJ_Datacore <[email protected]>
AJDatacore
requested review from
avishnu,
datacore-tilangovan and
tiagolobocastro
…the top as requested Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
quickstart/performance-tips.md
Outdated
| @@ -93,17 +93,46 @@ cat /sys/devices/system/cpu/isolated | |||
| {% endtab %} | |||
| {% endtabs %} | |||
|
|
|||
| ### Deploy Mayastor daemonset | |||
| ### Deploy IO-engine daemonset | |||
There was a problem hiding this comment.
There's no deploy of the daemonset now, it's all done via helm or kubectl edit.
Should we also show the helm command to change the coreList? CC @niladrih
Suggested change
| ### Deploy IO-engine daemonset | |
| ### Modify the io-engine daemonset |
There was a problem hiding this comment.
The core list set command for installation and upgrade would be a good idea. I'll test this one out, and post here.
There was a problem hiding this comment.
Install command argument: --set 'io_engine.coreList={30,31}'
Upgrade command argument: --set-args 'io_engine.coreList={30,31}'
Need to have the single quotes around it.
Signed-off-by: AJ_Datacore <[email protected]>
Signed-off-by: AJ_Datacore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.