Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(performance-tips): added steps to deploy io engine deamonset #160

Merged
merged 7 commits into from
Aug 31, 2023
Merged

docs(performance-tips): added steps to deploy io engine deamonset #160

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83c5483
docs(performance-tips): added steps to deploy io engine deamonset
AJDatacore Aug 14, 2023
38c0cd5
docs(performance-tips): modified stem sentence and moved the note to …
AJDatacore Aug 14, 2023
6f0e3c0
docs(performance-tips): note edited
AJDatacore Aug 14, 2023
216ba6f
docs(performance-tips): made minor changes
AJDatacore Aug 14, 2023
8e13d9e
docs: changed steps for cpu core specification
AJDatacore Aug 29, 2023
a9f3132
docs: changed link
AJDatacore Aug 30, 2023
406e972
Merge branch 'develop' into deploy-etcd-change
AJDatacore Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 38 additions & 9 deletions quickstart/performance-tips.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,46 @@ cat /sys/devices/system/cpu/isolated
{% endtab %}
{% endtabs %}

### Deploy Mayastor daemonset
### Deploy IO-engine daemonset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no deploy of the daemonset now, it's all done via helm or kubectl edit.
Should we also show the helm command to change the coreList? CC @niladrih

Suggested change
### Deploy IO-engine daemonset
### Modify the io-engine daemonset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core list set command for installation and upgrade would be a good idea. I'll test this one out, and post here.

Copy link
Member

@niladrih niladrih Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install command argument: --set 'io_engine.coreList={30,31}'
Upgrade command argument: --set-args 'io_engine.coreList={30,31}'

Need to have the single quotes around it.


Edit the `mayastor-daemonset.yaml` file and set the `-l` parameter of mayastor to specify CPU cores that Mayastor reactors should run on. In the following example we run mayastor on the third and fourth CPU core:
Edit the `io-engine` daemonset and set the `-l` parameter of mayastor to specify CPU cores that Mayastor reactors should run on. In the following example we run mayastor on the third and fourth CPU core:

```yaml
...
containers:
- name: mayastor
1. Verify the current status of the `mayastor-io-engine` DaemonSet using the following command:

{% tabs %}
{% tab title="Command" %}
```text
kubectl get ds mayastor-io-engine -n mayastor
```
{% endtab %}

{% tab title="Output" %}
```text
NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE
mayastor-io-engine 3 3 3 0 3 kubernetes.io/arch=amd64,openebs.io/engine=mayastor 22d
```
{% endtab %}
{% endtabs %}

2. Edit the `mayastor-io-engine` DaemonSet configuration using the `kubectl edit` command:

```
kubectl edit ds mayastor-io-engine -n mayastor
```

> This will open the DaemonSet configuration in your default text editor.

3. Locate the section that defines the `io-engine` container within the DaemonSet configuration.

```
...
containers:
- name: io-engine
...
args:
...
args:
...
- "-l3,4"
- "-l2,3"

```

4. Save the changes and exit the text editor.
Loading