Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Profile image on user posts (quince.master) #575

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link
Contributor

Description

  • Added profile image on user avatar posts

Screenshot 2023-10-11 at 19 01 23

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 12, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 12, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@eb127cd). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #575   +/-   ##
=============================================================
  Coverage                              ?   92.32%           
=============================================================
  Files                                 ?      169           
  Lines                                 ?     3455           
  Branches                              ?      903           
=============================================================
  Hits                                  ?     3190           
  Misses                                ?      244           
  Partials                              ?       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023
@awais-ansari
Copy link
Contributor

@vladislavkeblysh This change was intentional. This feature is still in product discussion.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/user-avatar-quince.master branch from 071f0a1 to 701497a Compare November 25, 2023 13:50
@arbrandes
Copy link
Contributor

Is this ready to merge?

@cmltaWt0
Copy link

It hasn't yet been merged with the master.
#574

@mphilbrick211
Copy link

Is this ready to merge?

@arbrandes we're waiting to see if Product needs to review.

@itsjeyd
Copy link

itsjeyd commented Dec 14, 2023

This change will need product approval before merging it, see #574 (comment).

@cmltaWt0 cmltaWt0 removed the product review PR requires product review before merging label Feb 8, 2024
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Backlog
Status: Product Review
Development

Successfully merging this pull request may close these issues.

7 participants