Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paragon & frontend-build to openedx scope along with major version bump for platform, header & footer #657

Closed
wants to merge 15 commits into from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jan 29, 2024

Description

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@BilalQamar95 BilalQamar95 self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (3a7b705) to head (afbe840).

❗ Current head afbe840 differs from pull request most recent head 66be5bb. Consider uploading reports for the commit 66be5bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   92.82%   92.84%   +0.01%     
==========================================
  Files         158      158              
  Lines        3331     3338       +7     
  Branches      919      921       +2     
==========================================
+ Hits         3092     3099       +7     
  Misses        219      219              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 changed the title feat: major version upgrades for frontend-platform & paragon Updated paragon & frontend-build to openedx scope along with major version bump for platform, header & footer Feb 20, 2024
@brian-smith-tcril
Copy link
Contributor

I'm going to close this because these changes made it in via #666 as they were blocking Tutor dev mode (#666 (comment)) and this was failing CI. Thanks for all the work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants