chore(deps): update paragon and frontend-build to openedx scope #666
Conversation
brian-smith-tcril
force-pushed
the
paragon-build-scope
branch
3 times, most recently
from
140f38f
to
2264354
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 158 158
Lines 3331 3331
Branches 919 919
=======================================
Hits 3092 3092
Misses 219 219
Partials 20 20 ☔ View full report in Codecov by Sentry. |
| await waitFor(async () => { | ||
| const stats = await sectionGroups[index].querySelectorAll('.icon-size:not([data-testid="subsection-group"].icon-size)'); | ||
| const subsectionGroups = await within(sectionGroups[index]).getAllByTestId('subsection-group'); | ||
|
|
||
| expect(within(sectionGroups[index]).queryByText(topic.displayName)).toBeInTheDocument(); | ||
| expect(stats).toHaveLength(0); | ||
| expect(subsectionGroups).toHaveLength(2); | ||
| expect(within(sectionGroups[index]).queryByText(topic.displayName)).toBeInTheDocument(); | ||
| expect(stats).toHaveLength(0); | ||
| expect(subsectionGroups).toHaveLength(2); | ||
| }); |
There was a problem hiding this comment.
This is the only non-package.json, non-find-and-replace-@edx-with-@openedx, non lint --fix change. The only difference is that the body of this forEach loop is now wrapped in waitFor.
|
it looks like this is likely a dupe of #657 |
arbrandes
force-pushed
the
paragon-build-scope
branch
from
2264354
to
e010d1e
Compare
|
This is now required for Tutor dev mode to work (see overhangio/tutor-mfe#193). Should we merge this one or #657? |
Looks like CI is failing on 657, I'll rebase this and see if it passes. |
brian-smith-tcril
force-pushed
the
paragon-build-scope
branch
from
e010d1e
to
421ced1
Compare
|
@brian-smith-tcril @arbrandes This PR change has broken the stage and production pipeline for discussion MFE. |
|
@awais-ansari it looks like you need to:
the |
|
@brian-smith-tcril Thanks for quick response. We have made some changes in internal and now build is green. |
No description provided.