Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: cleanup etcd member update from lca as it was moved to recert #656

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Sep 17, 2024

Background / Context

We want all the etcd operations to be part of recert. After implementing rh-ecosystem-edge/recert#161 in recert , cleaning up lca code

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Removing not relevant code

Other Information

@openshift-ci-robot
Copy link

@tsorya: This pull request explicitly references no jira issue.

In response to this:

Background / Context

We want all the etcd operations to be part of recert. After implementing rh-ecosystem-edge/recert#161 in recert , cleaning up lca code

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@tsorya: This pull request explicitly references no jira issue.

In response to this:

Background / Context

We want all the etcd operations to be part of recert. After implementing rh-ecosystem-edge/recert#161 in recert , cleaning up lca code

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Removing not relevant code

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@omertuc
Copy link
Collaborator

omertuc commented Sep 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@omertuc
Copy link
Collaborator

omertuc commented Sep 18, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@tsorya
Copy link
Contributor Author

tsorya commented Sep 18, 2024

/retest

1 similar comment
@tsorya
Copy link
Contributor Author

tsorya commented Sep 18, 2024

/retest

@omertuc
Copy link
Collaborator

omertuc commented Sep 19, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ae15554 into openshift-kni:main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants