Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] [EXPERIMENTAL] FullyConnected: enabled sparsity weights decompression #13775

Merged
merged 1 commit into from
Dec 4, 2022
Merged

[CPU] [EXPERIMENTAL] FullyConnected: enabled sparsity weights decompression #13775

merged 1 commit into from
Dec 4, 2022

Conversation

antonvor
Copy link
Contributor

@antonvor antonvor commented Nov 2, 2022 •
edited
Loading

Issue: 77198
PR in onednn fork: openvinotoolkit/oneDNN#158

@dmitry-gorokhov dmitry-gorokhov added the category: CPU OpenVINO CPU plugin label Nov 2, 2022
@dmitry-gorokhov dmitry-gorokhov added this to the 2022.3 milestone Nov 2, 2022
@antonvor antonvor marked this pull request as ready for review November 3, 2022 08:51
@antonvor antonvor requested review from a team as code owners November 3, 2022 08:51
@antonvor antonvor self-assigned this Nov 3, 2022
@antonvor antonvor force-pushed the feature/sparsity branch 2 times, most recently from 336824f to cf1003c Compare November 7, 2022 00:19
dmitry-gorokhov
dmitry-gorokhov reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OV part

src/bindings/python/src/pyopenvino/core/properties/properties.cpp Outdated Show resolved Hide resolved
src/tests/ie_test_utils/common_test_utils/ov_tensor_utils.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.h Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/graph.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/functional/subgraph_tests/src/fullyconnected_sparse.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Outdated Show resolved Hide resolved
@antonvor antonvor force-pushed the feature/sparsity branch 2 times, most recently from 98920d7 to df9b32c Compare November 23, 2022 19:11
@antonvor antonvor changed the title WIP: [CPU] [EXPERIMENTAL] FullyConnected: enabled sparsity weights decompression [CPU] [EXPERIMENTAL] FullyConnected: enabled sparsity weights decompression Nov 24, 2022
@usstq usstq mentioned this pull request Dec 1, 2022
Closed
dmitry-gorokhov
dmitry-gorokhov approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgmt.
We need to follow up in separate PRs:

  1. Fix remaining comments and and corresponding tests.
  2. Update user documentation

src/inference/include/openvino/runtime/intel_cpu/properties.hpp Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.cpp Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/fullyconnected.h Show resolved Hide resolved
@dmitry-gorokhov dmitry-gorokhov merged commit 3caebff into openvinotoolkit:master Dec 4, 2022
@antonvor antonvor mentioned this pull request Jan 3, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@antonvor antonvor

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2022.3
Development

Successfully merging this pull request may close these issues.
2 participants
@antonvor @dmitry-gorokhov