[CPU] FullyConnected: sparsity weights decompression leftovers #14901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonvor
force-pushed
the
feature/sparsity_leftovers
branch
from
423e4d0
to
92ed322
Compare
| @@ -47,7 +47,7 @@ namespace intel_cpu { | |||
| */ | |||
| static constexpr Property<bool> denormals_optimization{"CPU_DENORMALS_OPTIMIZATION"}; | |||
|
|
|||
| static constexpr Property<float> sparse_weights_decompression_rate{"SPARSE_WEIGHTS_DECOMPRESSION_RATE"}; | |||
| static constexpr Property<float> sparse_weights_decompression_rate{"CPU_SPARSE_WEIGHTS_DECOMPRESSION_RATE"}; | |||
There was a problem hiding this comment.
I suppose it's not a BW compatible change if users used string name?
There was a problem hiding this comment.
Unfortunately, yes, I didn't fix it after merging my previous PR #13775
There was a problem hiding this comment.
so, why do we need to change the name now?
There was a problem hiding this comment.
because it's a bug that's hasn't been fixed. Currently, we can't use c++ or python api to set this property, we will get error " [ NOT_FOUND ] Unsupported property SPARSE_WEIGHTS_DECOMPRESSION_RATE by CPU plugin"
antonvor
changed the title
github-actions
bot
added
category: CPP API
antonvor
force-pushed
the
feature/sparsity_leftovers
branch
from
20edcb3
to
47faadd
Compare
antonvor
requested review from
kblaszczak-intel
and removed request for
a team
antonvor
changed the title
|
@dmitry-gorokhov could you please start review? |
…n case [CPU][oneDNN] sparsity: some fixes and removed unused code [CPU][TESTS] FullyConnected: sparsity weights decompression tests [CPU] FullyConnected: removed min sparse rate = 0.5 limitation [CPU] fixed property CPU_SPARSE_WEIGHTS_DECOMPRESSION_RATE [CPU][TESTS] added CPU_SPARSE_WEIGHTS_DECOMPRESSION_RATE test [CPU][DOC] doc dixes
|
changes have been included in this PR #15918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes for previous PR: #13775
CPU_SPARSE_WEIGHTS_DECOMPRESSION_RATEpropertyTODO:
CPU_SPARSE_WEIGHTS_DECOMPRESSION_RATEPR in oneDNN: openvinotoolkit/oneDNN#171