Override the default isExecutable() method in StringTensorPack-15
#28376
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
mitruska
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
The default isExecutable() returns false if any input Tensor has 0 dimension.
As I understand, for StringTensorPack the last input tensor with char values is allowed to be empty, while the output shape is always equal to the shape of the first input, so for such case the output tensor can be non-empty, but contains "" empty strings.
The solution LGTM.
Comment on lines
+84
to
+87
| bool StringTensorPack::isExecutable() const { | ||
| return !(isInputTensorAtPortEmpty(0) || isInputTensorAtPortEmpty(1)); | ||
| } | ||
|
|
There was a problem hiding this comment.
It's great that the issue is fixed for the reproducer script, but is it possible to add a unit test to cover such case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
isExecutable()method inStringTensorPack-15Tickets: