Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the default isExecutable() method in StringTensorPack-15 #28376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Override the default isExecutable() method in StringTensorPack-15 #28376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f3c0f
Add isExecutable()
p-wysocki Jan 10, 2025
79c59e9
Cleanup
p-wysocki Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/plugins/intel_cpu/src/nodes/string_tensor_pack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ struct StringTensorPack::StringTensorPackExecute {
}
};

bool StringTensorPack::isExecutable() const {
return !(isInputTensorAtPortEmpty(0) || isInputTensorAtPortEmpty(1));
}

Comment on lines +84 to +87
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that the issue is fixed for the reproducer script, but is it possible to add a unit test to cover such case?

void StringTensorPack::execute(dnnl::stream strm) {
auto indicesPrecision = getParentEdgeAt(0)->getMemory().getDesc().getPrecision();
StringTensorPackContext ctx = {*this};
Expand Down
1 change: 1 addition & 0 deletions src/plugins/intel_cpu/src/nodes/string_tensor_pack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class StringTensorPack : public Node {
static bool isSupportedOperation(const std::shared_ptr<const ov::Node>& op, std::string& errorMessage) noexcept;
void getSupportedDescriptors() override;
void initSupportedPrimitiveDescriptors() override;
bool isExecutable() const override;
void execute(dnnl::stream strm) override;
bool created() const override;
bool needPrepareParams() const override;
Expand Down
Loading