Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle failing mmap on FileReader. #867

Merged
merged 5 commits into from
Apr 3, 2024

Throw MMapException if mmap fail.

916afdf
Select commit
Loading
Failed to load commit list.
Merged

Correctly handle failing mmap on FileReader. #867

Throw MMapException if mmap fail.
916afdf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Apr 3, 2024 in 1s

76.92% of diff hit (target 90.00%)

View this Pull Request on Codecov

76.92% of diff hit (target 90.00%)

Annotations

Check warning on line 154 in src/file_reader.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/file_reader.cpp#L154 

Added line #L154 was not covered by tests
View more details on Codecov