Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle failing mmap on FileReader. #867

Merged
merged 5 commits into from
Apr 3, 2024

Throw MMapException if mmap fail.

916afdf
Select commit
Loading
Failed to load commit list.
Merged

Correctly handle failing mmap on FileReader. #867

Throw MMapException if mmap fail.
916afdf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2024 in 0s

58.07% (+0.07%) compared to 48da5b8

View this Pull Request on Codecov

58.07% (+0.07%) compared to 48da5b8

Details

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (48da5b8) to head (916afdf).

Files Patch % Lines
src/file_reader.cpp 71.42% 1 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   58.00%   58.07%   +0.07%     
==========================================
  Files         101      101              
  Lines        4622     4623       +1     
  Branches     1923     1922       -1     
==========================================
+ Hits         2681     2685       +4     
+ Misses        667      665       -2     
+ Partials     1274     1273       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.