-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert border none #630
Closed
MatthewKennedy
wants to merge
60
commits into
orchidjs:master
from
RemoteDevForce:revert-border-none
Closed
Revert border none #630
MatthewKennedy
wants to merge
60
commits into
orchidjs:master
from
RemoteDevForce:revert-border-none
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code already uses calc() in some places, so using it instead of add() is safe. Because Bootstrap 5.3 is using more and more CSS variables, we need to use color-mix() which has an good evergreen browser support : https://caniuse.com/?search=color-mix To maintain Bootstrap 5.0 to 5.2 compatibility for older browsers, a separate "tom-select.bootstrap5.3.scss" file should be create with this code. There was an SASS deprecation warning with Bootstrap 4 that's also fixed.
Fix/css warnings
fix: updatd the syntax for the sass to fix the compile error
fix: updated the karma configs and fixed the peer dependencies
Feature/test runner fix
chore: skipped failing tests
chore: disable achecker in karma
use http://127.0.0.1:8000/ not local host for checking broken links
Revert border none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts border none change.