Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert border none #630

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
231ab7f
Add stylelint
MatthewKennedy Dec 12, 2022
24d3a1f
Add workflow and clean up.
MatthewKennedy Dec 12, 2022
96f52bd
Improve SCSS format
MatthewKennedy Dec 12, 2022
4f9c173
Manual tidy up
MatthewKennedy Dec 12, 2022
5faef75
stylelint --fix
MatthewKennedy Dec 12, 2022
55fe01d
Remove extra white space.
MatthewKennedy Dec 12, 2022
4630bfd
Remove unused style.
MatthewKennedy Dec 12, 2022
fa340eb
Convert tabs to spaces.
MatthewKennedy Dec 19, 2022
a5ec389
As per fix.
MatthewKennedy Dec 19, 2022
37db787
Merge branch 'master' into fix/css-warnings
MatthewKennedy Dec 19, 2022
9545541
Remove commented out css
MatthewKennedy Dec 19, 2022
1cfc606
Use editor config formatting.
MatthewKennedy Dec 23, 2022
b5543b0
Ensure using tabs
MatthewKennedy Dec 23, 2022
67de3cc
Fix indentation.
MatthewKennedy Dec 23, 2022
dab8599
Fix indention.
MatthewKennedy Dec 23, 2022
04e2c60
Adapt Bootstrap 5 SCSS for Bootstrap 5.3+
czj Jun 2, 2023
1b9d82f
Merge pull request #1 from MatthewKennedy/fix/css-warnings
craigh Jul 14, 2023
c714a8b
Add stylelint
MatthewKennedy Dec 12, 2022
a070449
Add workflow and clean up.
MatthewKennedy Dec 12, 2022
472ec60
Improve SCSS format
MatthewKennedy Dec 12, 2022
98ed95b
Manual tidy up
MatthewKennedy Dec 12, 2022
24ee7e2
stylelint --fix
MatthewKennedy Dec 12, 2022
d5f2777
Remove extra white space.
MatthewKennedy Dec 12, 2022
0366c5b
Remove unused style.
MatthewKennedy Dec 12, 2022
0710e61
Convert tabs to spaces.
MatthewKennedy Dec 19, 2022
8bec34b
Remove commented out css
MatthewKennedy Dec 19, 2022
1c52e3b
Use editor config formatting.
MatthewKennedy Dec 23, 2022
2b49ff1
Ensure using tabs
MatthewKennedy Dec 23, 2022
77b89be
Fix indentation.
MatthewKennedy Dec 23, 2022
54fef53
Fix indention.
MatthewKennedy Dec 23, 2022
7273a92
Merge branch 'levups-bootstrap-5.3-support'
craigh Jul 14, 2023
f973ff0
Update tom-select.scss
craigh Jul 15, 2023
8841354
fix: updatd the syntax for the sass to fix the compile error
Robert430404 Jul 17, 2023
317ad2b
Merge pull request #3 from RemoteDevForce/feature/scss-fix
craigh Jul 17, 2023
7b9ce35
updates
craigh Jul 17, 2023
39518ab
updates
craigh Jul 17, 2023
af51004
fix: updated the karma configs and fixed the peer dependencies
Robert430404 Jul 20, 2023
7d5bb80
Merge pull request #4 from RemoteDevForce/feature/karma-fix
craigh Jul 20, 2023
1345dc8
chore: added in package lock
Robert430404 Jul 20, 2023
84ed635
fix: updated the karma config to support the headless browser runners
Robert430404 Jul 20, 2023
397ac5c
Merge pull request #5 from RemoteDevForce/feature/test-runner-fix
craigh Jul 20, 2023
4c622fd
chore: skipped failing tests
Robert430404 Jul 21, 2023
b3703bd
chore: reverted back change
Robert430404 Jul 21, 2023
4355e3d
Merge pull request #6 from RemoteDevForce/feature/a11y-skip
craigh Jul 21, 2023
3e6d8df
chore: disable achecker in karma
Robert430404 Jul 21, 2023
a1f284d
Merge pull request #7 from RemoteDevForce/feature/disable-achecker
craigh Jul 21, 2023
60eb1e2
Update CHANGELOG
craigh Jul 21, 2023
b7ba71b
Update CHANGELOG
craigh Jul 21, 2023
677ae7e
Update release.sh
craigh Jul 21, 2023
3cd964b
v2.2.3 Release
craigh Jul 21, 2023
0586ceb
v2.2.4 Release
craigh Jul 21, 2023
e6441a1
correct scss path
craigh Jul 25, 2023
deedeee
correct syntax
craigh Jul 25, 2023
17a22ee
prepare release
craigh Jul 25, 2023
5f522ff
use http://127.0.0.1:8000/ not local host for checking broken links
MatthewKennedy Aug 26, 2023
bc14166
Fix extra border and padding.
MatthewKennedy Aug 28, 2023
0cbdde2
Merge pull request #14 from RemoteDevForce/fix-local-dev
MatthewKennedy Aug 28, 2023
35d4377
update readme for fork
craigh Sep 15, 2023
10a7d5d
prepare release
craigh Sep 15, 2023
336d6bd
Update tom-select.bootstrap5.scss
MatthewKennedy Sep 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
267 changes: 134 additions & 133 deletions .config/karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,185 +1,186 @@
module.exports = function(config) {

var customLaunchers = {};

if (process.env.TARGET === 'browserstack') {

module.exports = function (config) {
let customLaunchers = {
HeadlessFirefox: {
base: "Firefox",
flags: ["-headless"],
},
HeadlessChrome: {
base: "ChromeHeadless",
flags: [
"--disable-translate",
"--disable-extensions",
"--remote-debugging-port=9223",
],
},
};
if (process.env.TARGET === "browserstack") {
// define browsers
// https://www.browserstack.com/automate/capabilities
customLaunchers = {

// ios
bs_ios_ffox:{
base: 'BrowserStack',
os : 'OS X',
os_version : 'Catalina',
browser : 'Firefox',
browser_version : 'latest',
bs_ios_ffox: {
base: "BrowserStack",
os: "OS X",
os_version: "Catalina",
browser: "Firefox",
browser_version: "latest",
},

bs_ios_safari14:{
base: 'BrowserStack',
os : 'OS X',
os_version : 'Big Sur',
browser : 'Safari',
browser_version : 'latest',
bs_ios_safari14: {
base: "BrowserStack",
os: "OS X",
os_version: "Big Sur",
browser: "Safari",
browser_version: "latest",
},

bs_ios_safari13:{
base: 'BrowserStack',
os : 'OS X',
os_version : 'Catalina',
browser : 'Safari',
browser_version : 'latest',
bs_ios_safari13: {
base: "BrowserStack",
os: "OS X",
os_version: "Catalina",
browser: "Safari",
browser_version: "latest",
},

bs_ios_safari12:{
base: 'BrowserStack',
os : 'OS X',
os_version : 'Mojave',
browser : 'Safari',
browser_version : 'latest',
bs_ios_safari12: {
base: "BrowserStack",
os: "OS X",
os_version: "Mojave",
browser: "Safari",
browser_version: "latest",
},

iphone11:{
base: 'BrowserStack',
os: 'iOS',
os_version: '14',
device: 'iPhone 11',
browser: 'iPhone',
real_mobile: 'true',
iphone11: {
base: "BrowserStack",
os: "iOS",
os_version: "14",
device: "iPhone 11",
browser: "iPhone",
real_mobile: "true",
},


// win
bs_win10_edge:{
base: 'BrowserStack',
os : 'Windows',
os_version : '10',
browser : 'Edge',
browser_version : 'latest',
bs_win10_edge: {
base: "BrowserStack",
os: "Windows",
os_version: "10",
browser: "Edge",
browser_version: "latest",
},

bs_win7_edge:{
base: 'BrowserStack',
os : 'Windows',
os_version : '7',
browser : 'Edge',
browser_version : '80.0',
bs_win7_edge: {
base: "BrowserStack",
os: "Windows",
os_version: "7",
browser: "Edge",
browser_version: "80.0",
},

bs_win10_chrome:{
base: 'BrowserStack',
os : 'Windows',
os_version : '10',
browser : 'Chrome',
browser_version : 'latest',
bs_win10_chrome: {
base: "BrowserStack",
os: "Windows",
os_version: "10",
browser: "Chrome",
browser_version: "latest",
},

// android
bs_android:{
base: 'BrowserStack',
os : 'Android',
os_version : '10.0',
device : 'Samsung Galaxy S20',
real_mobile : 'true',
browser : 'Android',
bs_android: {
base: "BrowserStack",
os: "Android",
os_version: "10.0",
device: "Samsung Galaxy S20",
real_mobile: "true",
browser: "Android",
},


};

}else{
customLaunchers['HeadlessFirefox'] = {
base: 'Firefox',
flags: [
'-headless',
]
};

customLaunchers['HeadlessChrome'] = {
base: 'ChromeHeadless',
flags: [
'--disable-translate',
'--disable-extensions',
'--remote-debugging-port=9223'
]
};
}

var targets = {
'browserstack': Object.keys(customLaunchers),
'HeadlessFirefox': ['HeadlessFirefox'],
'HeadlessChrome': ['HeadlessChrome']
const targets = {
browserstack: Object.keys(customLaunchers),
HeadlessFirefox: ["HeadlessFirefox"],
HeadlessChrome: ["HeadlessChrome"],
};

var reporters = ['mocha','coverage','aChecker'];
if( process.env.TRAVIS_CI ){
reporters = ['mocha', 'coverage', 'coveralls','aChecker']
const reporters = [
"mocha",
"coverage",
// "aChecker"
];
if (process.env.TRAVIS_CI) {
reporters.push("coveralls");
}

var target = process.env.TARGET;
if( !target ){
target = 'HeadlessChrome';
process.env.CHROME_BIN = require('puppeteer').executablePath();
}


var browsers = targets[target];
if( process.env.BROWSERS ){
browsers = process.env.BROWSERS.split(',');
const target = process.env.TARGET || "HeadlessChrome";
if (target === "HeadlessChrome") {
process.env.CHROME_BIN = require("puppeteer").executablePath();
}

const browsers = process.env.BROWSERS
? process.env.BROWSERS.split(",")
: targets[target];

config.set({
basePath: '../',
frameworks: ['mocha', 'chai','aChecker'],
const builtConfig = {
browsers,
reporters,
basePath: "../",
customLaunchers: customLaunchers,
colors: true,
logLevel: config.LOG_INFO,
singleRun: true,
browserDisconnectTolerance: 3,
browserDisconnectTimeout: 15000,
browserNoActivityTimeout: 120000,
concurrency: 3,
plugins: [
require("karma-coverage"),
"karma-mocha-reporter",
"karma-mocha",
require("karma-chai"),
require("karma-firefox-launcher"),
require("karma-chrome-launcher"),
"karma-sourcemap-loader",
],
frameworks: [
"mocha",
"chai",
// "aChecker"
],
files: [
{
pattern: 'test/tests/esm-module.js',
type: 'module',
pattern: "test/tests/esm-module.js",
type: "module",
included: true,
},

'build/js/tom-select.complete.js',
'node_modules/syn/dist/global/syn.js',
'node_modules/jquery/dist/jquery.js',
'build/css/tom-select.default.css',
'test/support/*.js',
config.test_one ? 'test/tests/interaction.js' : 'test/tests/**/*.js',
"build/js/tom-select.complete.js",
"node_modules/syn/dist/global/syn.js",
"node_modules/jquery/dist/jquery.js",
"build/css/tom-select.default.css",
"test/support/*.js",
config.test_one
? "test/tests/interaction.js"
: "test/tests/**/*.js",

{
pattern: 'build/**/*',
pattern: "build/**/*",
included: false,
},

],
preprocessors: {
'build/**/*.js': ['sourcemap','coverage'],
"build/**/*.js": ["sourcemap", "coverage"],
},
coverageReporter: {
reporters:[
{type: 'lcov'},
{type: 'text-summary'},

],
dir: 'coverage/'
reporters: [{ type: "lcov" }, { type: "text-summary" }],
dir: "coverage/",
},
browserStack: {
tunnelIdentifier: process.env.TRAVIS_JOB_NUMBER,
build: process.env.TRAVIS_BUILD_NUMBER,
project: process.env.TRAVIS_CI ? 'tom-select': '',
name: process.env.TRAVIS_CI ? 'tom-select': '',
project: process.env.TRAVIS_CI ? "tom-select" : "",
name: process.env.TRAVIS_CI ? "tom-select" : "",
},
customLaunchers: customLaunchers,
reporters: reporters,
colors: true,
logLevel: config.LOG_INFO,
browsers: browsers,
singleRun: true,
browserDisconnectTolerance: 3,
browserDisconnectTimeout: 15000,
browserNoActivityTimeout: 120000,
concurrency: 3,
});
};

config.set(builtConfig);
};
34 changes: 34 additions & 0 deletions .github/workflows/stylelint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: StyleLint

on:
pull_request:
branches:
- '*'
push:
branches:
- main

jobs:
prettier:
name: StyleLint Check Action
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '16.x'
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v1
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Yarn install
run: yarn
- name: Run Stylelint Check
run: yarn stylelint
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
node_modules
*.log
*.tmp.*
package-lock.json
*.lock
build/*
build-docs/*
Expand All @@ -14,3 +13,5 @@ coverage/
stats/
src/tom-select.custom.ts
dist
/vendor/
/.idea/
12 changes: 12 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"extends": [
"stylelint-config-standard-scss",
"stylelint-config-prettier-scss"
],

"rules": {
"selector-class-pattern": null,
"scss/no-global-function-names": null,
"scss/dollar-variable-pattern": null
}
}
10 changes: 10 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Version 2.2.23 (17 July 2023)
=============================
- Merge [PR #534](https://github.com/orchidjs/tom-select/pull/534) from original repo.
- Fix SCSS Warnings - from @MatthewKennedy
- Merge [PR #601](https://github.com/orchidjs/tom-select/pull/601) from original repo.
- Adapt Bootstrap 5 SCSS for Bootstrap 5.3+ = from @czj
- Update syntax to allow SASS to compile properly from @Robert430404
- Refactored the karma configs to properly load plugins locally from @Robert430404
- Added package lock to pin the versions of packages from @Robert430404
- Disabled a11y tests due to non-conformance from @Robert430404
Loading
Loading