Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioParam: Use a single Arc for shared properties #301

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

uklotzde
Copy link
Contributor

Stripped down successor of #297

@github-actions
Copy link

Benchmark result:


bench_ctor
  Instructions:             5134557 (-0.058899%)
  L1 Accesses:              7700321 (-0.056628%)
  L2 Accesses:                54101 (-0.033260%)
  RAM Accesses:               61573 (+0.004873%)
  Estimated Cycles:        10125881 (-0.042921%)

bench_sine
  Instructions:            78180296 (-0.004676%)
  L1 Accesses:            115134642 (+0.004070%)
  L2 Accesses:               263538 (-3.645936%)
  RAM Accesses:               62659 (+0.009577%)
  Estimated Cycles:       118645397 (-0.037883%)

bench_sine_gain
  Instructions:            82926506 (-0.013507%)
  L1 Accesses:            122321769 (-0.009244%)
  L2 Accesses:               282112 (-0.564303%)
  RAM Accesses:               62817 (+0.015922%)
  Estimated Cycles:       125930924 (-0.015056%)

bench_sine_gain_delay
  Instructions:           157035198 (-0.002571%)
  L1 Accesses:            223540436 (-0.001947%)
  L2 Accesses:               721737 (-0.208643%)
  RAM Accesses:               64500 (+0.003101%)
  Estimated Cycles:       229406621 (-0.005155%)

bench_buffer_src
  Instructions:            18570521 (-0.021890%)
  L1 Accesses:             26910860 (-0.035973%)
  L2 Accesses:                96688 (+4.185164%)
  RAM Accesses:               96111 (+0.014569%)
  Estimated Cycles:        30758185 (+0.033257%)

bench_buffer_src_delay
  Instructions:            91611448 (-0.048125%)
  L1 Accesses:            126761589 (-0.063556%)
  L2 Accesses:               216050 (+2.080351%)
  RAM Accesses:               96304 (+0.009346%)
  Estimated Cycles:       131212479 (-0.044401%)

bench_buffer_src_iir
  Instructions:            42554534 (-0.009667%)
  L1 Accesses:             61849292 (-0.021664%)
  L2 Accesses:               106422 (+7.576294%)
  RAM Accesses:               96209 (+0.010395%)
  Estimated Cycles:        65748717 (+0.037160%)

bench_buffer_src_biquad
  Instructions:            38983732 (-0.033651%)
  L1 Accesses:             54929469 (-0.010270%)
  L2 Accesses:               157336 (-5.934965%)
  RAM Accesses:               96317 (+0.008307%)
  Estimated Cycles:        59087244 (-0.092991%)

bench_stereo_positional
  Instructions:            46302581 (-0.014058%)
  L1 Accesses:             68633276 (+0.065711%)
  L2 Accesses:               717252 (-7.038245%)
  RAM Accesses:               96497 (+0.011401%)
  Estimated Cycles:        75596931 (-0.298148%)

bench_stereo_panning_automation
  Instructions:            32662902 (-0.012266%)
  L1 Accesses:             48683472 (-0.052023%)
  L2 Accesses:               170812 (+12.95521%)
  RAM Accesses:               96238 (+0.010392%)
  Estimated Cycles:        52905862 (+0.138105%)

bench_analyser_node
  Instructions:            39115769 (-0.011493%)
  L1 Accesses:             54858006 (-0.009507%)
  L2 Accesses:               192376 (-0.707111%)
  RAM Accesses:               96801 (+0.004132%)
  Estimated Cycles:        59207921 (-0.020139%)


@orottier
Copy link
Owner

Thanks. I think this strikes a sweet spot in the layout of the AudioParam pieces!

@orottier orottier merged commit 37aa007 into orottier:main Jun 21, 2023
@uklotzde uklotzde deleted the audioparam branch June 21, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants