Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure no link using empty string net #646

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

chungshien-chai
Copy link
Contributor

@chungshien-chai chungshien-chai commented May 14, 2024

This is the misc improvement to make sure we do not link primitives using empty string net.

This maybe happen if user does not connect data path ports. Example

  • one primitive O-port is unconnected (maybe have empty string - but if the connection does not exists in the first place in the cell, then that is ok).
  • another primitive I-port is unconncetd as well (maybe have empty string).
  • If we allow empty string as a net to search the connection, we might end up linking these two primitives.

Testing:

  • ported code to latest NS Raptor manually
  • run batch, batch_gen2 (no run on batch_gen3)

@alaindargelas alaindargelas merged commit 9e3c0ef into main May 14, 2024
1 check passed
@alaindargelas alaindargelas deleted the yosys-config-json branch May 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants