Adv+ac/phylogenetic trees #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adv+ac/phylogenetic-trees
…adv+ac/phylogenetic-trees
|
It might make sense to move the phylogenetic stuff to a separate file ? |
lgoettgens
reviewed
Feb 6, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
+ Coverage 81.82% 81.84% +0.02%
==========================================
Files 556 557 +1
Lines 74358 74410 +52
==========================================
+ Hits 60843 60903 +60
+ Misses 13515 13507 -8
|
benlorenz
reviewed
Feb 9, 2024
benlorenz
reviewed
Feb 9, 2024
benlorenz
reviewed
Feb 9, 2024
benlorenz
reviewed
Feb 9, 2024
Co-authored-by: Benjamin Lorenz <[email protected]>
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
* Some helpful functions for MPI meeting
* phylogenetic trees
* some clean up
* get properties with julia types
* Tropical median consensus added
* export consensus
* docs for phylo functions
* doc tropical median consensus
* tropical_median_consensus to md file
* add intro doc phylogenetics
* added some test skeleton and some docs
* remove doc for now
* added more stuff to tests
* add fix for QQField matrix type
* fix printing
* fix tests
* eliminate duplicate in exports.jl
* remove the unused param T
* change where T in Varargs{phylo}
* removed spaces around where
* change deprecated where
* this might fix the export issues
* removed undefined method from exports
* trying to fix arg types
* fixing vararg
* removed swp file
* add undirected adjacency
* i think this might work
* remove vararg function
* trying again with signature
* use splat
* adjacency_tree returns a directed graph now
* update tests
* makes some type and signature fixes and adjustments to tests
* Revert "Merge remote-tracking branch 'andrei/adv+ac/phylogenetic-trees' into adv+ac/phylogenetic-trees"
This reverts commit 38f47b2, reversing
changes made to 09ac0f8.
* moves graph from edges up out of phylo trees section
* some restructuring
* Revert "some restructuring"
This reverts commit 0a9d603.
* new phylogenetic trees file
* returning graph from edges to the bottom of file + add include
* Update src/Combinatorics/Graphs/functions.jl
* removed swp file
* Update src/Combinatorics/Graphs/functions.jl
* updates from review comments
* make Phylogenetic tree immutable
* Apply suggestions from code review
Co-authored-by: Benjamin Lorenz <[email protected]>
---------
Co-authored-by: Antony Della Vecchia <[email protected]>
Co-authored-by: antonydellavecchia <[email protected]>
Co-authored-by: Andrei Comaneci <[email protected]>
Co-authored-by: Benjamin Lorenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added phylogenetic functionalities in oscar