Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a vcat #3580

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix a vcat #3580

merged 2 commits into from
Apr 10, 2024

Conversation

joschmitt
Copy link
Member

vcat shouldn't work for matrices over different base rings and here it does so just by accident.

(Also replaces some glueings by gluings.)

@joschmitt joschmitt mentioned this pull request Apr 10, 2024
Merged
@thofma thofma added the backport 1.0.x Should be backported to the release 1.0 branch label Apr 10, 2024
@thofma
Copy link
Collaborator

thofma commented Apr 10, 2024

This exploits a bug in the current implementation, which we want to fix.

@lgoettgens
Copy link
Member

Note for backporting: The relevant part is the vcat. The gluing may be dropped if creating conflicts or it doesn't exist on the release branch yet.

@thofma thofma merged commit b7a2a2e into oscar-system:master Apr 10, 2024
24 checks passed
@joschmitt joschmitt deleted the js/vcat branch April 11, 2024 08:12
@benlorenz benlorenz mentioned this pull request Apr 11, 2024
Merged
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joschmitt @thofma @lgoettgens @benlorenz