Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a vcat #3580

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix a vcat #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed30f55
Fix a `vcat`
joschmitt Apr 10, 2024
fbc2114
Don't use glueing
joschmitt Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions experimental/Schemes/Resolution_structure.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ function find_refinement_with_local_system_of_params(W::AbsAffineScheme; check::
minor_dict[U_ij] = (indices(I), indices(J), M_ext[i, j])
end
res_cov = Covering(ref_patches)
inherit_glueings!(res_cov, Covering(W))
inherit_gluings!(res_cov, Covering(W))
return res_cov, minor_dict
end

Expand Down Expand Up @@ -694,9 +694,9 @@ function common_refinement(list::Vector{<:Covering}, def_cov::Covering)
!match_found && error("no common ancestor found for $U and $V")
end
#anc_cov = Covering(anc_list)
#inherit_glueings!(anc_cov, def_cov)
#inherit_gluings!(anc_cov, def_cov)
result = Covering(patch_list)
inherit_glueings!(result, def_cov)
inherit_gluings!(result, def_cov)

tot_inc1 = CoveringMorphism(result, list[1], to_U_dict; check=false)
tot_inc2 = CoveringMorphism(result, list[2], to_V_dict; check=false)
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/mpolyquo-localizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function has_solution(A::MatrixType, b::MatrixType) where {T<:MPolyQuoLocRingEle
R = base_ring(S)
S === base_ring(b) || error("matrices must be defined over the same ring")
nrows(b) == 1 || error("only matrices with one row are allowed!")
Aext = vcat(A, modulus_matrix(S, ncols(A)))
Aext = vcat(A, change_base_ring(S, modulus_matrix(S, ncols(A))))
B, D = clear_denominators(Aext)
c, u = clear_denominators(b)
(success, y, v) = has_solution(B, c, inverted_set(S))
Expand Down
Loading