Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the usual problems with caching (x-ref e.g. #2455), I noticed that the caches for Lie algebras have very extended keys: for linear Lie algebras, a whole basis was part of the cache-key, while for abstract lie algebras the structure constant table. Both are IMO too enormous to take as a key here.
Furthermore, I cannot come up with any non-trivial (interactive) example where one really needs this kind of caching.
Aside from this, fixed some minor things in docstrings, and with correct propagation of
check
kwargs.