Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching of Lie algebras #3894

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

lgoettgens
Copy link
Member

Apart from the usual problems with caching (x-ref e.g. #2455), I noticed that the caches for Lie algebras have very extended keys: for linear Lie algebras, a whole basis was part of the cache-key, while for abstract lie algebras the structure constant table. Both are IMO too enormous to take as a key here.
Furthermore, I cannot come up with any non-trivial (interactive) example where one really needs this kind of caching.

Aside from this, fixed some minor things in docstrings, and with correct propagation of check kwargs.

@lgoettgens lgoettgens added topic: LieTheory experimental Only changes experimental parts of the code labels Jun 28, 2024
@lgoettgens lgoettgens requested a review from fingolfin June 28, 2024 13:55
@lgoettgens lgoettgens closed this Jul 1, 2024
@lgoettgens lgoettgens reopened this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.91%. Comparing base (5acca40) to head (bf5979d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3894      +/-   ##
==========================================
+ Coverage   83.87%   83.91%   +0.04%     
==========================================
  Files         589      589              
  Lines       80864    81301     +437     
==========================================
+ Hits        67823    68224     +401     
- Misses      13041    13077      +36     
Files Coverage Δ
experimental/LieAlgebras/src/AbstractLieAlgebra.jl 73.39% <100.00%> (-0.25%) ⬇️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LieAlgebras/src/LinearLieAlgebra.jl 94.01% <100.00%> (-0.04%) ⬇️
experimental/LieAlgebras/src/iso_gap_oscar.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/LieAlgebra.jl 86.16% <0.00%> (ø)

... and 5 files with indirect coverage changes

@lgoettgens lgoettgens merged commit f2697ea into oscar-system:master Jul 1, 2024
53 of 56 checks passed
@lgoettgens lgoettgens deleted the lg/nocache-Lie-algebras branch July 1, 2024 21:37
simonbrandhorst pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants