-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TropicalGeometry + PolyhedralGeometry: fixing references in documentation #3923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3923 +/- ##
==========================================
+ Coverage 84.55% 84.57% +0.01%
==========================================
Files 596 597 +1
Lines 81994 82179 +185
==========================================
+ Hits 69330 69502 +172
- Misses 12664 12677 +13
|
b39eac6
to
c3a97ae
Compare
Modulo bugs that are currently affecting the entire documentation, see #4009, I think the pull request is ready to be reviewed. The goal of the pull request is to make the documentation more explicit whilst keeping it slim by adding references to same-named functions in polyhedral geometry. |
@lkastner Could you review the changes for me, please? I've had to add some bits to the documentation in polyhedral geometry, let me know if you are okay with that. |
20697e3
to
112b83b
Compare
7b5e034
to
25a4090
Compare
Co-authored-by: Tommy Hofmann <[email protected]>
fe0bffb
to
4c36ba7
Compare
…tion (oscar-system#3923) Co-authored-by: Tommy Hofmann <[email protected]>
Beginning fixing some documentation as discussed in #3915
Does anybody know how to correctly add a reference to the function
rays
for polyhedral complexes? Currently,[`rays(::PolyhedralComplex)`](@ref)
links torays
forK3Chamber
.