Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global variables and disable a check #3925

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

simonbrandhorst
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (e89929a) to head (ab759bf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3925      +/-   ##
==========================================
- Coverage   83.99%   83.69%   -0.31%     
==========================================
  Files         591      591              
  Lines       81384    81314      -70     
==========================================
- Hits        68357    68054     -303     
- Misses      13027    13260     +233     
Files Coverage Δ
experimental/Schemes/src/elliptic_surface.jl 87.25% <83.33%> (-0.05%) ⬇️

... and 37 files with indirect coverage changes

@lgoettgens lgoettgens added topic: schemes experimental Only changes experimental parts of the code labels Jul 10, 2024
@fingolfin fingolfin merged commit 686a746 into master Jul 10, 2024
28 of 30 checks passed
@fingolfin fingolfin deleted the sb/elliptic_fixes branch July 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: schemes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants